diff options
| author | Matthew Pickering <matthewtpickering@gmail.com> | 2019-02-11 09:24:04 +0000 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2019-02-14 02:36:02 -0500 |
| commit | 19626218566ea709b5f6f287d3c296b0c4021de2 (patch) | |
| tree | d22f486e543a19670be2ae88e8e358f99e1e54fd /libraries | |
| parent | 1d9a1d9fb8fe0a1fea2c44c4246f102ff3e1f3a3 (diff) | |
| download | haskell-19626218566ea709b5f6f287d3c296b0c4021de2.tar.gz | |
Implement -Wredundant-record-wildcards and -Wunused-record-wildcards
-Wredundant-record-wildcards warns when a .. pattern binds no variables.
-Wunused-record-wildcards warns when none of the variables bound by a ..
pattern are used.
These flags are enabled by `-Wall`.
Diffstat (limited to 'libraries')
| -rw-r--r-- | libraries/base/GHC/IO/Handle.hs | 4 | ||||
| -rw-r--r-- | libraries/ghc-heap/GHC/Exts/Heap/Closures.hs | 2 | ||||
| -rw-r--r-- | libraries/ghci/GHCi/TH.hs | 2 | ||||
| -rw-r--r-- | libraries/libiserv/src/Lib.hs | 2 |
4 files changed, 5 insertions, 5 deletions
diff --git a/libraries/base/GHC/IO/Handle.hs b/libraries/base/GHC/IO/Handle.hs index 01c226dfbd..720eef575b 100644 --- a/libraries/base/GHC/IO/Handle.hs +++ b/libraries/base/GHC/IO/Handle.hs @@ -604,7 +604,7 @@ hSetBinaryMode handle bin = -- data is flushed first. hSetNewlineMode :: Handle -> NewlineMode -> IO () hSetNewlineMode handle NewlineMode{ inputNL=i, outputNL=o } = - withAllHandles__ "hSetNewlineMode" handle $ \h_@Handle__{..} -> + withAllHandles__ "hSetNewlineMode" handle $ \h_@Handle__{} -> do flushBuffer h_ return h_{ haInputNL=i, haOutputNL=o } @@ -705,7 +705,7 @@ dupHandleTo :: FilePath -> Maybe HandleFinalizer -> IO Handle__ dupHandleTo filepath h other_side - hto_@Handle__{haDevice=devTo,..} + hto_@Handle__{haDevice=devTo} h_@Handle__{haDevice=dev} mb_finalizer = do flushBuffer h_ case cast devTo of diff --git a/libraries/ghc-heap/GHC/Exts/Heap/Closures.hs b/libraries/ghc-heap/GHC/Exts/Heap/Closures.hs index a3f9b9729e..e624a17b78 100644 --- a/libraries/ghc-heap/GHC/Exts/Heap/Closures.hs +++ b/libraries/ghc-heap/GHC/Exts/Heap/Closures.hs @@ -313,7 +313,7 @@ allClosures (APClosure {..}) = fun:payload allClosures (PAPClosure {..}) = fun:payload allClosures (APStackClosure {..}) = fun:payload allClosures (BCOClosure {..}) = [instrs,literals,bcoptrs] -allClosures (ArrWordsClosure {..}) = [] +allClosures (ArrWordsClosure {}) = [] allClosures (MutArrClosure {..}) = mccPayload allClosures (MutVarClosure {..}) = [var] allClosures (MVarClosure {..}) = [queueHead,queueTail,value] diff --git a/libraries/ghci/GHCi/TH.hs b/libraries/ghci/GHCi/TH.hs index d9f4443d14..09df787db3 100644 --- a/libraries/ghci/GHCi/TH.hs +++ b/libraries/ghci/GHCi/TH.hs @@ -265,7 +265,7 @@ runTH pipe rstate rhv ty mb_loc = do runTHQ :: Binary a => Pipe -> RemoteRef (IORef QState) -> Maybe TH.Loc -> TH.Q a -> IO ByteString -runTHQ pipe@Pipe{..} rstate mb_loc ghciq = do +runTHQ pipe rstate mb_loc ghciq = do qstateref <- localRef rstate qstate <- readIORef qstateref let st = qstate { qsLocation = mb_loc, qsPipe = pipe } diff --git a/libraries/libiserv/src/Lib.hs b/libraries/libiserv/src/Lib.hs index 57e65706c3..0c478d3bf5 100644 --- a/libraries/libiserv/src/Lib.hs +++ b/libraries/libiserv/src/Lib.hs @@ -13,7 +13,7 @@ import Data.Binary type MessageHook = Msg -> IO Msg serv :: Bool -> MessageHook -> Pipe -> (forall a .IO a -> IO a) -> IO () -serv verbose hook pipe@Pipe{..} restore = loop +serv verbose hook pipe restore = loop where loop = do Msg msg <- readPipe pipe getMessage >>= hook |