summaryrefslogtreecommitdiff
path: root/llvm-targets
diff options
context:
space:
mode:
authorSimon Peyton Jones <simonpj@microsoft.com>2020-10-08 13:01:47 +0100
committerMarge Bot <ben+marge-bot@smart-cactus.org>2020-10-14 18:06:48 -0400
commit15d2340cb9dc833adb87784e6de86dba235290f7 (patch)
tree38bf0e9e0f88e44e6bce91fb11d4ca7a1997e73d /llvm-targets
parente60ae8a38394370fd8818ad004a101466fc7d2dc (diff)
downloadhaskell-15d2340cb9dc833adb87784e6de86dba235290f7.tar.gz
Fix some missed opportunities for preInlineUnconditionally
There are two signficant changes here: * Ticket #18815 showed that we were missing some opportunities for preInlineUnconditionally. The one-line fix is in the code for GHC.Core.Opt.Simplify.Utils.preInlineUnconditionally, which now switches off only for INLINE pragmas. I expanded Note [Stable unfoldings and preInlineUnconditionally] to explain. * When doing this I discovered a way in which preInlineUnconditionally was occasionally /too/ eager. It's all explained in Note [Occurrences in stable unfoldings] in GHC.Core.Opt.OccurAnal, and the one-line change adding markAllMany to occAnalUnfolding. I also got confused about what NoUserInline meant, so I've renamed it to NoUserInlinePrag, and changed its pretty-printing slightly. That led to soem error messate wibbling, and touches quite a few files, but there is no change in functionality. I did a nofib run. As expected, no significant changes. Program Size Allocs ---------------------------------------- sphere -0.0% -0.4% ---------------------------------------- Min -0.0% -0.4% Max -0.0% +0.0% Geometric Mean -0.0% -0.0% I'm allowing a max-residency increase for T10370, which seems very irreproducible. (See comments on !4241.) There is always sampling error for max-residency measurements; and in any case the change shows up on some platforms but not others. Metric Increase: T10370
Diffstat (limited to 'llvm-targets')
0 files changed, 0 insertions, 0 deletions