summaryrefslogtreecommitdiff
path: root/mk
diff options
context:
space:
mode:
authorJoachim Breitner <mail@joachim-breitner.de>2021-10-14 18:57:54 +0200
committerMarge Bot <ben+marge-bot@smart-cactus.org>2021-10-24 01:27:57 -0400
commit3417a81a34fdf74857138a105b2ab4ee32e658c4 (patch)
tree22e4f7228512698fa93bc093d463be96f7ad6939 /mk
parent691c450f1e9cc3fd83b662be3c0134fde03e97db (diff)
downloadhaskell-3417a81a34fdf74857138a105b2ab4ee32e658c4.tar.gz
undefined: Neater CallStack in error message
Users of `undefined` don’t want to see ``` files.hs: Prelude.undefined: CallStack (from HasCallStack): error, called at libraries/base/GHC/Err.hs:79:14 in base:GHC.Err undefined, called at file.hs:151:19 in main:Main ``` but want to see ``` files.hs: Prelude.undefined: CallStack (from HasCallStack): undefined, called at file.hs:151:19 in main:Main ``` so let’s make that so. The function for that is `withFrozenCallStack`, but that is not usable here (module dependencies, and also not representation-polymorphic). And even if it were, it could confuse GHC’s strictness analyzer, leading to big regressions in some perf tests (T10421 in particular). So after shuffling modules and definitions around, I eventually noticed that the easiest way is to just not call `error` here. Fixes #19886
Diffstat (limited to 'mk')
0 files changed, 0 insertions, 0 deletions