diff options
| author | Tamar Christina <tamar@zhox.com> | 2016-01-27 10:20:11 +0100 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2016-01-27 10:26:47 +0100 |
| commit | 44a5d51a4892b85c7eba09dcb90ca02245637812 (patch) | |
| tree | 4150f6359e80bcb8ba0aabf99cefc23bcab8f07f /mk | |
| parent | e2bdf03a63b09feabee76e2efd33eb56739324ac (diff) | |
| download | haskell-44a5d51a4892b85c7eba09dcb90ca02245637812.tar.gz | |
Enable RemoteGHCi on Windows
Makes the needed changes to make RemoteGHCi work on Windows.
The approach passes OS Handles areound instead of the Posix Fd
as on Linux.
The reason is that I could not find any real documentation about
the behaviour of Windows w.r.t inheritance and Posix FDs.
The implementation with Fd did not seem to be able to find the Fd
in the child process. Instead I'm using the much better documented
approach of passing inheriting handles.
This requires a small modification to the `process` library.
https://github.com/haskell/process/pull/52
Test Plan: ./validate On Windows x86_64
Reviewers: thomie, erikd, bgamari, simonmar, austin, hvr
Reviewed By: simonmar
Subscribers: #ghc_windows_task_force
Differential Revision: https://phabricator.haskell.org/D1836
GHC Trac Issues: #11100
Diffstat (limited to 'mk')
| -rw-r--r-- | mk/warnings.mk | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/mk/warnings.mk b/mk/warnings.mk index abbee68735..10c0935348 100644 --- a/mk/warnings.mk +++ b/mk/warnings.mk @@ -61,6 +61,11 @@ ifeq "$(HostOS_CPP)" "mingw32" libraries/time_dist-install_EXTRA_HC_OPTS += -Wno-unused-imports -Wno-identities endif +# On Windows, the pattern for CallConv is already exaustive. Ignore the warning +ifeq "$(HostOS_CPP)" "mingw32" +libraries/ghci_dist-install_EXTRA_HC_OPTS += -Wno-overlapping-patterns +endif + # haskeline has warnings about deprecated use of block/unblock libraries/haskeline_dist-install_EXTRA_HC_OPTS += -Wno-deprecations libraries/haskeline_dist-install_EXTRA_HC_OPTS += -Wno-unused-imports |