diff options
author | Tamar Christina <tamar@zhox.com> | 2018-01-26 13:10:10 -0500 |
---|---|---|
committer | Ben Gamari <ben@smart-cactus.org> | 2018-01-26 14:37:29 -0500 |
commit | a55d581f8f2923560c3444253050b13fdf2dec10 (patch) | |
tree | a93dfe88e55530b362bf1cd15bc7dd928121749a /nofib | |
parent | 9a57cfebd2e65109884712a27a0f29d1a71f57b7 (diff) | |
download | haskell-a55d581f8f2923560c3444253050b13fdf2dec10.tar.gz |
Fix Windows stack allocations.
On Windows we use the function `win32AllocStack` to do stack
allocations in 4k blocks and insert a stack check afterwards
to ensure the allocation returned a valid block.
The problem is this function does something that by C semantics
is pointless. The stack allocated value can never escape the
function, and the stack isn't used so the compiler just optimizes
away the entire function body.
After considering a bunch of other possibilities I think the simplest
fix is to just disable optimizations for the function.
Alternatively inline assembly is an option but the stack check function
doesn't have a very portable name as it relies on e.g. `libgcc`.
Thanks to Sergey Vinokurov for helping diagnose and test.
Test Plan: ./validate
Reviewers: bgamari, erikd, simonmar
Reviewed By: bgamari
Subscribers: rwbarton, thomie, carter
GHC Trac Issues: #14669
Differential Revision: https://phabricator.haskell.org/D4343
Diffstat (limited to 'nofib')
0 files changed, 0 insertions, 0 deletions