diff options
author | Simon Marlow <marlowsd@gmail.com> | 2018-07-16 19:58:31 -0400 |
---|---|---|
committer | Ben Gamari <ben@smart-cactus.org> | 2018-07-16 19:59:08 -0400 |
commit | 3bdf0d01ff47977830ada30ce85f174098486e23 (patch) | |
tree | a7bcd3a6842b1cc793ce990e924d157a408f93f0 /rts/Heap.c | |
parent | c4b8e719effe9b420b1c5cec0194134a44b26823 (diff) | |
download | haskell-3bdf0d01ff47977830ada30ce85f174098486e23.tar.gz |
Support the GHCi debugger with -fexternal-interpreter
* All the tests in tests/ghci.debugger now pass with
-fexternal-interpreter. These tests are now run with the ghci-ext way
in addition to the normal way so we won't break it in the future.
* I removed all the unsafeCoerce# calls from RtClosureInspect. Yay!
The main changes are:
* New messages: GetClosure and Seq. GetClosure is a remote interface to
GHC.Exts.Heap.getClosureData, which required Binary instances for
various datatypes. Fortunately this wasn't too painful thanks to
DeriveGeneric.
* No cheating by unsafeCoercing values when printing them. Now we have
to turn the Closure representation back into the native representation
when printing Int, Float, Double, Integer and Char. Of these, Integer
was the most painful - we now have a dependency on integer-gmp due to
needing access to the representation.
* Fixed a bug in rts/Heap.c - it was bogusly returning stack content as
pointers for an AP_STACK closure.
Test Plan:
* `cd testsuite/tests/ghci.debugger && make`
* validate
Reviewers: bgamari, patrickdoc, nomeata, angerman, hvr, erikd, goldfire
Subscribers: alpmestan, snowleopard, rwbarton, thomie, carter
GHC Trac Issues: #13184
Differential Revision: https://phabricator.haskell.org/D4955
Diffstat (limited to 'rts/Heap.c')
-rw-r--r-- | rts/Heap.c | 11 |
1 files changed, 8 insertions, 3 deletions
diff --git a/rts/Heap.c b/rts/Heap.c index 7ab628d2da..dfd32aff0c 100644 --- a/rts/Heap.c +++ b/rts/Heap.c @@ -162,9 +162,14 @@ StgMutArrPtrs *heap_view_closurePtrs(Capability *cap, StgClosure *closure) { case AP_STACK: ptrs[nptrs++] = ((StgAP_STACK *)closure)->fun; - for (i = 0; i < ((StgAP_STACK *)closure)->size; ++i) { - ptrs[nptrs++] = ((StgAP_STACK *)closure)->payload[i]; - } + /* + The payload is a stack, which consists of a mixture of pointers + and non-pointers. We can't simply pretend it's all pointers, + because that will cause crashes in the GC later. We could + traverse the stack and extract pointers and non-pointers, but that + would be complicated, so let's just ignore the payload for now. + See #15375. + */ break; case BCO: |