summaryrefslogtreecommitdiff
path: root/rts/Linker.c
diff options
context:
space:
mode:
authorSimon Marlow <marlowsd@gmail.com>2015-11-07 09:39:05 +0000
committerSimon Marlow <marlowsd@gmail.com>2015-11-07 09:39:05 +0000
commitce1f1607ed7f8fedd2f63c8610cafefd59baaf32 (patch)
tree718641160c3d93a2ca974deec1e228cb09e1a97e /rts/Linker.c
parenta58eeb7febd67c93dab82de7049ef1dcdecd34e9 (diff)
downloadhaskell-ce1f1607ed7f8fedd2f63c8610cafefd59baaf32.tar.gz
Make GHCi & TH work when the compiler is built with -prof
Summary: Amazingly, there were zero changes to the byte code generator and very few changes to the interpreter - mainly because we've used good abstractions that hide the differences between profiling and non-profiling. So that bit was pleasantly straightforward, but there were a pile of other wibbles to get the whole test suite through. Note that a compiler built with -prof is now like one built with -dynamic, in that to use TH you have to build the code the same way. For dynamic, we automatically enable -dynamic-too when TH is required, but we don't have anything equivalent for profiling, so you have to explicitly use -prof when building code that uses TH with a profiled compiler. For this reason Cabal won't work with TH. We don't expect to ship a profiled compiler, so I think that's OK. Test Plan: validate with GhcProfiled=YES in validate.mk Reviewers: goldfire, bgamari, rwbarton, austin, hvr, erikd, ezyang Reviewed By: ezyang Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D1407 GHC Trac Issues: #4837, #545
Diffstat (limited to 'rts/Linker.c')
-rw-r--r--rts/Linker.c19
1 files changed, 16 insertions, 3 deletions
diff --git a/rts/Linker.c b/rts/Linker.c
index fb7653960b..0507c9c268 100644
--- a/rts/Linker.c
+++ b/rts/Linker.c
@@ -31,6 +31,7 @@
#include "GetEnv.h"
#include "Stable.h"
#include "RtsSymbols.h"
+#include "Profiling.h"
#if !defined(mingw32_HOST_OS)
#include "posix/Signals.h"
@@ -1831,9 +1832,15 @@ static HsInt loadArchive_ (pathchar *path)
IF_DEBUG(linker,
debugBelch("loadArchive: Found member file `%s'\n", fileName));
- isObject = thisFileNameSize >= 2
- && fileName[thisFileNameSize - 2] == '.'
- && fileName[thisFileNameSize - 1] == 'o';
+ isObject =
+ (thisFileNameSize >= 2 &&
+ fileName[thisFileNameSize - 2] == '.' &&
+ fileName[thisFileNameSize - 1] == 'o')
+ || (thisFileNameSize >= 4 &&
+ fileName[thisFileNameSize - 4] == '.' &&
+ fileName[thisFileNameSize - 3] == 'p' &&
+ fileName[thisFileNameSize - 2] == '_' &&
+ fileName[thisFileNameSize - 1] == 'o');
IF_DEBUG(linker, debugBelch("loadArchive: \tthisFileNameSize = %d\n", (int)thisFileNameSize));
IF_DEBUG(linker, debugBelch("loadArchive: \tisObject = %d\n", isObject));
@@ -2260,6 +2267,12 @@ static HsInt resolveObjs_ (void)
oc->status = OBJECT_RESOLVED;
}
}
+
+#ifdef PROFILING
+ // collect any new cost centres & CCSs that were defined during runInit
+ initProfiling2();
+#endif
+
IF_DEBUG(linker, debugBelch("resolveObjs: done\n"));
return 1;
}