diff options
| author | David Feuer <david.feuer@gmail.com> | 2018-08-29 16:34:21 -0400 |
|---|---|---|
| committer | David Feuer <David.Feuer@gmail.com> | 2018-08-29 16:34:22 -0400 |
| commit | f48e276a5ba68d8b6fcb4a558022581fb30f9326 (patch) | |
| tree | 8ea324b84d137d59cda566d6a559016d2c7437ea /rts/RetainerProfile.c | |
| parent | 65eec9cfd4410c0e30b0ed06116c15f8ce3de49d (diff) | |
| download | haskell-f48e276a5ba68d8b6fcb4a558022581fb30f9326.tar.gz | |
Finish stable split
Long ago, the stable name table and stable pointer tables were one.
Now, they are separate, and have significantly different
implementations. I believe the time has come to finish the split
that began in #7674.
* Divide `rts/Stable` into `rts/StableName` and `rts/StablePtr`.
* Give each table its own mutex.
* Add FFI functions `hs_lock_stable_ptr_table` and
`hs_unlock_stable_ptr_table` and document them.
These are intended to replace the previously undocumented
`hs_lock_stable_tables` and `hs_lock_stable_tables`,
which are now documented as deprecated synonyms.
* Make `eqStableName#` use pointer equality instead of unnecessarily
comparing stable name table indices.
Reviewers: simonmar, bgamari, erikd
Reviewed By: bgamari
Subscribers: rwbarton, carter
GHC Trac Issues: #15555
Differential Revision: https://phabricator.haskell.org/D5084
Diffstat (limited to 'rts/RetainerProfile.c')
| -rw-r--r-- | rts/RetainerProfile.c | 7 |
1 files changed, 5 insertions, 2 deletions
diff --git a/rts/RetainerProfile.c b/rts/RetainerProfile.c index 8a64de9e14..d67eeb4834 100644 --- a/rts/RetainerProfile.c +++ b/rts/RetainerProfile.c @@ -30,7 +30,8 @@ #include "Stats.h" #include "ProfHeap.h" #include "Apply.h" -#include "Stable.h" /* markStableTables */ +#include "StablePtr.h" /* markStablePtrTable */ +#include "StableName.h" /* rememberOldStableNameAddresses */ #include "sm/Storage.h" // for END_OF_STATIC_LIST /* Note [What is a retainer?] @@ -1693,7 +1694,9 @@ computeRetainerSet( void ) } // Consider roots from the stable ptr table. - markStableTables(retainRoot, NULL); + markStablePtrTable(retainRoot, NULL); + // Remember old stable name addresses. + rememberOldStableNameAddresses (); // The following code resets the rs field of each unvisited mutable // object (computing sumOfNewCostExtra and updating costArray[] when |