summaryrefslogtreecommitdiff
path: root/rts/RtsAPI.c
diff options
context:
space:
mode:
authorSimon Marlow <marlowsd@gmail.com>2016-09-26 12:07:05 +0100
committerSimon Marlow <marlowsd@gmail.com>2018-05-16 13:36:13 +0100
commiteb8e692cab7970c495681e14721d05ecadd21581 (patch)
tree178cabcdff120f707ab31560086bf85753462cd1 /rts/RtsAPI.c
parenta18e7dfabd234af8b55d3280f9375e5e83facca1 (diff)
downloadhaskell-eb8e692cab7970c495681e14721d05ecadd21581.tar.gz
An overhaul of the SRT representation
Summary: - Previously we would hvae a single big table of pointers per module, with a set of bitmaps to reference entries within it. The new representation is identical to a static constructor, which is much simpler for the GC to traverse, and we get to remove the complicated bitmap-traversal code from the GC. - Rewrite all the code to generate SRTs in CmmBuildInfoTables, and document it much better (see Note [SRTs]). This has been something I've wanted to do since we moved to the new code generator, I finally had the opportunity to finish it while on a transatlantic flight recently :) There are a series of 4 diffs: 1. D4632 (this one), which does the bulk of the changes 2. D4633 which adds support for smaller `CmmLabelDiffOff` constants 3. D4634 which takes advantage of D4632 and D4633 to save a word in info tables that have an SRT on x86_64. This is where most of the binary size improvement comes from. 4. D4637 which makes a further optimisation to merge some SRTs with static FUN closures. This adds some complexity and the benefits are fairly modest, so it's not clear yet whether we should do this. Results (after (3), on x86_64) - GHC itself (staticaly linked) is 5.2% smaller - -1.7% binary sizes in nofib, -2.9% module sizes. Full nofib results: P176 - I measured the overhead of traversing all the static objects in a major GC in GHC itself by doing `replicateM_ 1000 performGC` as the first thing in `Main.main`. The new version was 5-10% faster, but the results did vary quite a bit. - I'm not sure if there's a compile-time difference, the results are too unreliable. Test Plan: validate Reviewers: bgamari, michalt, niteria, simonpj, erikd, osa1 Subscribers: thomie, carter Differential Revision: https://phabricator.haskell.org/D4632
Diffstat (limited to 'rts/RtsAPI.c')
-rw-r--r--rts/RtsAPI.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/rts/RtsAPI.c b/rts/RtsAPI.c
index 533c0c41d4..8946f9d840 100644
--- a/rts/RtsAPI.c
+++ b/rts/RtsAPI.c
@@ -367,7 +367,7 @@ rts_getBool (HaskellObj p)
const StgInfoTable *info;
info = get_itbl((const StgClosure *)UNTAG_CONST_CLOSURE(p));
- if (info->srt_bitmap == 0) { // srt_bitmap is the constructor tag
+ if (info->has_srt == 0) { // has_srt is the constructor tag
return 0;
} else {
return 1;