summaryrefslogtreecommitdiff
path: root/rts/Task.c
diff options
context:
space:
mode:
authorMichal Terepeta <michal.terepeta@gmail.com>2018-05-13 18:34:03 -0400
committerBen Gamari <ben@smart-cactus.org>2018-05-13 18:34:09 -0400
commiteb39f98891482366cf1130fe58d728b93f0dd49f (patch)
tree94c7adf6e8d239ea6f97853264cd8dd9fb7b6593 /rts/Task.c
parent7c665f9ce0980ee7c81a44c8f861686395637453 (diff)
downloadhaskell-eb39f98891482366cf1130fe58d728b93f0dd49f.tar.gz
Fix a few GCC warnings
GCC 8 now generates warnings for incompatible function pointer casts [-Werror=cast-function-type]. Apparently there are a few of those in rts code, which makes `./validate` unhappy (since we compile with `-Werror`) This commit tries to fix these issues by changing the functions to have the correct type (and, if necessary, moving the casts into those functions). For instance, hash/comparison function are declared (`Hash.h`) to take `StgWord` but we want to use `StgWord64[2]` in `StaticPtrTable.c`. Instead of casting the function pointers, we can cast the `StgWord` parameter to `StgWord*`. I think this should be ok since `StgWord` should be the same size as a pointer. Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com> Test Plan: ./validate Reviewers: bgamari, erikd, simonmar Reviewed By: bgamari Subscribers: rwbarton, thomie, carter Differential Revision: https://phabricator.haskell.org/D4673
Diffstat (limited to 'rts/Task.c')
-rw-r--r--rts/Task.c4
1 files changed, 3 insertions, 1 deletions
diff --git a/rts/Task.c b/rts/Task.c
index 758ae10ffc..ac86311844 100644
--- a/rts/Task.c
+++ b/rts/Task.c
@@ -416,7 +416,7 @@ workerTaskStop (Task *task)
#if defined(THREADED_RTS)
-static void OSThreadProcAttr
+static void* OSThreadProcAttr
workerStart(Task *task)
{
Capability *cap;
@@ -442,6 +442,8 @@ workerStart(Task *task)
traceTaskCreate(task, cap);
scheduleWorker(cap,task);
+
+ return NULL;
}
/* N.B. must take all_tasks_mutex */