diff options
| author | Simon Marlow <marlowsd@gmail.com> | 2009-01-12 12:10:24 +0000 |
|---|---|---|
| committer | Simon Marlow <marlowsd@gmail.com> | 2009-01-12 12:10:24 +0000 |
| commit | 6a405b1efd138a4af4ed93ce4ff173a4c5704512 (patch) | |
| tree | d11e6ba4cb32b3c447065b0e928e245d6639058d /rts/Updates.h | |
| parent | 192c7d555448b8a78d57a5c01c0c20f642f2d0f3 (diff) | |
| download | haskell-6a405b1efd138a4af4ed93ce4ff173a4c5704512.tar.gz | |
Keep the remembered sets local to each thread during parallel GC
This turns out to be quite vital for parallel programs:
- The way we discover which threads to traverse is by finding
dirty threads via the remembered sets (aka mutable lists).
- A dirty thread will be on the remembered set of the capability
that was running it, and we really want to traverse that thread's
stack using the GC thread for the capability, because it is in
that CPU's cache. If we get this wrong, we get penalised badly by
the memory system.
Previously we had per-capability mutable lists but they were
aggregated before GC and traversed by just one of the GC threads.
This resulted in very poor performance particularly for parallel
programs with deep stacks.
Now we keep per-capability remembered sets throughout GC, which also
removes a lock (recordMutableGen_sync).
Diffstat (limited to 'rts/Updates.h')
| -rw-r--r-- | rts/Updates.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/rts/Updates.h b/rts/Updates.h index 98e9e5a553..10fa09b0e5 100644 --- a/rts/Updates.h +++ b/rts/Updates.h @@ -268,7 +268,7 @@ no_slop: write_barrier(); \ bd = Bdescr((P_)p1); \ if (bd->gen_no != 0) { \ - recordMutableGenLock(p1, &generations[bd->gen_no]); \ + recordMutableGenLock(p1, bd->gen_no); \ SET_INFO(p1, &stg_IND_OLDGEN_info); \ TICK_UPD_OLD_IND(); \ and_then; \ |