diff options
| author | Michal Terepeta <michal.terepeta@gmail.com> | 2018-05-13 18:34:03 -0400 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2018-05-13 18:34:09 -0400 |
| commit | eb39f98891482366cf1130fe58d728b93f0dd49f (patch) | |
| tree | 94c7adf6e8d239ea6f97853264cd8dd9fb7b6593 /rts/posix | |
| parent | 7c665f9ce0980ee7c81a44c8f861686395637453 (diff) | |
| download | haskell-eb39f98891482366cf1130fe58d728b93f0dd49f.tar.gz | |
Fix a few GCC warnings
GCC 8 now generates warnings for incompatible function pointer casts
[-Werror=cast-function-type]. Apparently there are a few of those in rts
code, which makes `./validate` unhappy (since we compile with `-Werror`)
This commit tries to fix these issues by changing the functions to have
the correct type (and, if necessary, moving the casts into those
functions).
For instance, hash/comparison function are declared (`Hash.h`) to take
`StgWord` but we want to use `StgWord64[2]` in `StaticPtrTable.c`.
Instead of casting the function pointers, we can cast the `StgWord`
parameter to `StgWord*`. I think this should be ok since `StgWord`
should be the same size as a pointer.
Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com>
Test Plan: ./validate
Reviewers: bgamari, erikd, simonmar
Reviewed By: bgamari
Subscribers: rwbarton, thomie, carter
Differential Revision: https://phabricator.haskell.org/D4673
Diffstat (limited to 'rts/posix')
| -rw-r--r-- | rts/posix/OSThreads.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/rts/posix/OSThreads.c b/rts/posix/OSThreads.c index 9cf42aa246..7dcf0eed15 100644 --- a/rts/posix/OSThreads.c +++ b/rts/posix/OSThreads.c @@ -134,7 +134,7 @@ int createOSThread (OSThreadId* pId, char *name STG_UNUSED, OSThreadProc *startProc, void *param) { - int result = pthread_create(pId, NULL, (void *(*)(void *))startProc, param); + int result = pthread_create(pId, NULL, startProc, param); if (!result) { pthread_detach(*pId); #if defined(HAVE_PTHREAD_SETNAME_NP) |