diff options
| author | Simon Marlow <marlowsd@gmail.com> | 2012-11-16 09:22:00 +0000 |
|---|---|---|
| committer | Simon Marlow <marlowsd@gmail.com> | 2012-11-16 11:26:20 +0000 |
| commit | 6d784c43592290ec16db8b7f0f2a012dff3ed497 (patch) | |
| tree | a317ef1fc1ee40883e92cde308c292f7125db2b7 /rts/sm/Evac.c | |
| parent | 97dc57c6e2bdbddd0a0170a283149a570a07179c (diff) | |
| download | haskell-6d784c43592290ec16db8b7f0f2a012dff3ed497.tar.gz | |
Add a write barrier for TVAR closures
This improves GC performance when there are a lot of TVars in the
heap. For instance, a TChan with a lot of elements causes a massive
GC drag without this patch.
There's more to do - several other STM closure types don't have write
barriers, so GC performance when there are a lot of threads blocked on
STM isn't great. But fixing the problem for TVar is a good start.
Diffstat (limited to 'rts/sm/Evac.c')
| -rw-r--r-- | rts/sm/Evac.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/rts/sm/Evac.c b/rts/sm/Evac.c index 0ac9e2623a..4dfbad7e37 100644 --- a/rts/sm/Evac.c +++ b/rts/sm/Evac.c @@ -540,13 +540,6 @@ loop: case WHITEHOLE: goto loop; - case MUT_VAR_CLEAN: - case MUT_VAR_DIRTY: - case MVAR_CLEAN: - case MVAR_DIRTY: - copy(p,info,q,sizeW_fromITBL(INFO_PTR_TO_STRUCT(info)),gen_no); - return; - // For ints and chars of low value, save space by replacing references to // these with closures with references to common, shared ones in the RTS. // @@ -646,6 +639,11 @@ loop: goto loop; } + case MUT_VAR_CLEAN: + case MUT_VAR_DIRTY: + case MVAR_CLEAN: + case MVAR_DIRTY: + case TVAR: case BLOCKING_QUEUE: case WEAK: case PRIM: |