diff options
author | Simon Marlow <simonmar@microsoft.com> | 2007-07-25 13:55:04 +0000 |
---|---|---|
committer | Simon Marlow <simonmar@microsoft.com> | 2007-07-25 13:55:04 +0000 |
commit | eb5791fe867f6441d270344298678f45ed4a75e4 (patch) | |
tree | 5c3618696d1eba5c5b1ca23dbd6bce112752ac4f /rts/win32/IOManager.c | |
parent | 681aad99cb29ce54f72ec2a916fb1aab0fa0fabb (diff) | |
download | haskell-eb5791fe867f6441d270344298678f45ed4a75e4.tar.gz |
FIX #1177, partially at least.
Now we don't wait for outstanding IO requests when shutting down at
program exit time, but we still wait when shutting down a DLL (via
hs_exit()). There ought to be a better way to do this, but
terminating the threads forcibly is not a good idea (it never is: the
thread might be holding a mutex when it dies, for example).
I plan to add some docs to the user guide to describe how to shut
down a DLL properly.
Diffstat (limited to 'rts/win32/IOManager.c')
-rw-r--r-- | rts/win32/IOManager.c | 28 |
1 files changed, 15 insertions, 13 deletions
diff --git a/rts/win32/IOManager.c b/rts/win32/IOManager.c index 6af42456ae..6e7cd25b7a 100644 --- a/rts/win32/IOManager.c +++ b/rts/win32/IOManager.c @@ -443,25 +443,27 @@ AddProcRequest ( void* proc, return depositWorkItem(reqID, wItem); } -void ShutdownIOManager ( void ) +void ShutdownIOManager ( rtsBool wait_threads ) { int num; SetEvent(ioMan->hExitEvent); - /* Wait for all worker threads to die. */ - for (;;) { - EnterCriticalSection(&ioMan->manLock); - num = ioMan->numWorkers; - LeaveCriticalSection(&ioMan->manLock); - if (num == 0) - break; - Sleep(10); + if (wait_threads) { + /* Wait for all worker threads to die. */ + for (;;) { + EnterCriticalSection(&ioMan->manLock); + num = ioMan->numWorkers; + LeaveCriticalSection(&ioMan->manLock); + if (num == 0) + break; + Sleep(10); + } + FreeWorkQueue(ioMan->workQueue); + CloseHandle(ioMan->hExitEvent); + free(ioMan); + ioMan = NULL; } - FreeWorkQueue(ioMan->workQueue); - CloseHandle(ioMan->hExitEvent); - free(ioMan); - ioMan = NULL; } /* Keep track of WorkItems currently being serviced. */ |