diff options
author | Ben Gamari <ben@smart-cactus.org> | 2015-08-31 22:39:13 +0200 |
---|---|---|
committer | Ben Gamari <ben@smart-cactus.org> | 2015-09-05 10:54:45 +0200 |
commit | 062feee4e7408ad5b9d882e5fed2c700e337db72 (patch) | |
tree | 5a683dc20960e9a245bc52bb38b5afa35d4c1cc1 /rts | |
parent | 96b986b669410cf4b6945d1039f9e16e54f4e53f (diff) | |
download | haskell-062feee4e7408ad5b9d882e5fed2c700e337db72.tar.gz |
tracing: Kill EVENT_STARTUP
This has been unnecessary for quite some time due to the create/delete
capability events.
Diffstat (limited to 'rts')
-rw-r--r-- | rts/RtsStartup.c | 3 | ||||
-rw-r--r-- | rts/Trace.c | 7 | ||||
-rw-r--r-- | rts/Trace.h | 24 | ||||
-rw-r--r-- | rts/eventlog/EventLog.c | 14 | ||||
-rw-r--r-- | rts/eventlog/EventLog.h | 2 |
5 files changed, 0 insertions, 50 deletions
diff --git a/rts/RtsStartup.c b/rts/RtsStartup.c index f6544b6aba..584c31ef81 100644 --- a/rts/RtsStartup.c +++ b/rts/RtsStartup.c @@ -176,9 +176,6 @@ hs_init_ghc(int *argc, char **argv[], RtsConfig rts_config) #ifdef TRACING initTracing(); #endif - /* Trace the startup event - */ - traceEventStartup(); /* initialise scheduler data structures (needs to be done before * initStorage()). diff --git a/rts/Trace.c b/rts/Trace.c index dab7347e5c..0ab636abf4 100644 --- a/rts/Trace.c +++ b/rts/Trace.c @@ -759,13 +759,6 @@ void traceThreadStatus_ (StgTSO *tso USED_IF_DEBUG) } } -void traceEventStartup_(int nocaps) -{ - if (eventlog_enabled) { - postEventStartup(nocaps); - } -} - #ifdef DEBUG void traceBegin (const char *str, ...) { diff --git a/rts/Trace.h b/rts/Trace.h index 31aefcb58d..c85167c8a2 100644 --- a/rts/Trace.h +++ b/rts/Trace.h @@ -242,8 +242,6 @@ void traceThreadLabel_(Capability *cap, void traceThreadStatus_ (StgTSO *tso); -void traceEventStartup_ (int n_caps); - /* * Events for describing capabilities and capability sets in the eventlog * @@ -298,7 +296,6 @@ void traceTaskDelete_ (Task *task); #define debugTraceCap(class, cap, str, ...) /* nothing */ #define traceThreadStatus(class, tso) /* nothing */ #define traceThreadLabel_(cap, tso, label) /* nothing */ -INLINE_HEADER void traceEventStartup_ (int n_caps STG_UNUSED) {}; #define traceCapEvent(cap, tag) /* nothing */ #define traceCapsetEvent(tag, capset, info) /* nothing */ #define traceWallClockTime_() /* nothing */ @@ -350,9 +347,6 @@ void dtraceUserMarkerWrapper(Capability *cap, char *msg); HASKELLEVENT_CREATE_SPARK_THREAD(cap, spark_tid) #define dtraceThreadLabel(cap, tso, label) \ HASKELLEVENT_THREAD_LABEL(cap, tso, label) -INLINE_HEADER void dtraceStartup (int num_caps) { - HASKELLEVENT_STARTUP(num_caps); -} #define dtraceCapCreate(cap) \ HASKELLEVENT_CAP_CREATE(cap) #define dtraceCapDelete(cap) \ @@ -442,7 +436,6 @@ INLINE_HEADER void dtraceStartup (int num_caps) { #define dtraceRequestParGc(cap) /* nothing */ #define dtraceCreateSparkThread(cap, spark_tid) /* nothing */ #define dtraceThreadLabel(cap, tso, label) /* nothing */ -INLINE_HEADER void dtraceStartup (int num_caps STG_UNUSED) {}; #define dtraceUserMsg(cap, msg) /* nothing */ #define dtraceUserMarker(cap, msg) /* nothing */ #define dtraceGcIdle(cap) /* nothing */ @@ -710,23 +703,6 @@ INLINE_HEADER void traceEventHeapLive(Capability *cap STG_UNUSED, dtraceEventHeapLive(heap_capset, heap_live); } -/* TODO: at some point we should remove this event, it's covered by - * the cap create/delete events. - */ -INLINE_HEADER void traceEventStartup(void) -{ - int n_caps; -#ifdef THREADED_RTS - // XXX n_capabilities hasn't been initialised yet - n_caps = RtsFlags.ParFlags.nNodes; -#else - n_caps = 1; -#endif - - traceEventStartup_(n_caps); - dtraceStartup(n_caps); -} - INLINE_HEADER void traceCapsetCreate(CapsetID capset STG_UNUSED, CapsetType capset_type STG_UNUSED) { diff --git a/rts/eventlog/EventLog.c b/rts/eventlog/EventLog.c index c55ac2c644..2153942648 100644 --- a/rts/eventlog/EventLog.c +++ b/rts/eventlog/EventLog.c @@ -62,7 +62,6 @@ char *EventDesc[] = { [EVENT_MIGRATE_THREAD] = "Migrate thread", [EVENT_THREAD_WAKEUP] = "Wakeup thread", [EVENT_THREAD_LABEL] = "Thread label", - [EVENT_STARTUP] = "Create capabilities", [EVENT_CAP_CREATE] = "Create capability", [EVENT_CAP_DELETE] = "Delete capability", [EVENT_CAP_DISABLE] = "Disable capability", @@ -312,7 +311,6 @@ initEventLogging(void) + sizeof(EventThreadID); break; - case EVENT_STARTUP: // (cap_count) case EVENT_CAP_CREATE: // (cap) case EVENT_CAP_DELETE: // (cap) case EVENT_CAP_ENABLE: // (cap) @@ -1022,18 +1020,6 @@ void postCapMsg(Capability *cap, char *msg, va_list ap) postLogMsg(&capEventBuf[cap->no], EVENT_LOG_MSG, msg, ap); } -void postEventStartup(EventCapNo n_caps) -{ - ACQUIRE_LOCK(&eventBufMutex); - ensureRoomForEvent(&eventBuf, EVENT_STARTUP); - - // Post a STARTUP event with the number of capabilities - postEventHeader(&eventBuf, EVENT_STARTUP); - postCapNo(&eventBuf, n_caps); - - RELEASE_LOCK(&eventBufMutex); -} - void postUserEvent(Capability *cap, EventTypeNum type, char *msg) { EventsBuf *eb; diff --git a/rts/eventlog/EventLog.h b/rts/eventlog/EventLog.h index 9c2f265970..abe7880fe4 100644 --- a/rts/eventlog/EventLog.h +++ b/rts/eventlog/EventLog.h @@ -49,8 +49,6 @@ void postUserEvent(Capability *cap, EventTypeNum type, char *msg); void postCapMsg(Capability *cap, char *msg, va_list ap); -void postEventStartup(EventCapNo n_caps); - /* * Post an event relating to a capability itself (create/delete/etc) */ |