diff options
| author | Matthew Pickering <matthewtpickering@gmail.com> | 2020-12-21 08:59:27 +0000 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2021-01-27 17:38:32 -0500 |
| commit | 925738839891b320b9436e7383d55dce2b8d4543 (patch) | |
| tree | 23b1eff30fedebfabb827193ac5259a06a13ef6b /testsuite/driver | |
| parent | 34a8a0e4cf188a30d2b4b65909f24185c80d071e (diff) | |
| download | haskell-925738839891b320b9436e7383d55dce2b8d4543.tar.gz | |
Deprecate -h flag
It is confusing that it defaults to two different things depending on
whether we are in the profiling way or not.
Use -hc if you have a profiling build
Use -hT if you have a normal build
Fixes #19031
Diffstat (limited to 'testsuite/driver')
| -rw-r--r-- | testsuite/driver/testlib.py | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/testsuite/driver/testlib.py b/testsuite/driver/testlib.py index 87a0bbb23d..1d058c8325 100644 --- a/testsuite/driver/testlib.py +++ b/testsuite/driver/testlib.py @@ -606,7 +606,7 @@ def have_thread_sanitizer( ) -> bool: # appears to change (up or down) when the underlying profile hasn't # really changed. To further minimize this effect we run with a single # generation (meaning we get a residency sample on every GC) with a small -# allocation area (as suggested in #17387). That's what +RTS -h -i0 will do. +# allocation area (as suggested in #17387). That's what +RTS -hT -i0 will do. # If you find that a test is flaky, sampling frequency can be adjusted by # shrinking the allocation area (+RTS -A64k, for example). # @@ -614,13 +614,13 @@ def have_thread_sanitizer( ) -> bool: # a change in one of these figures, please check whether it is real or # not as follows: # -# * Run the test with old and new compilers, adding +RTS -h -i0.001 +# * Run the test with old and new compilers, adding +RTS -hT -i0.001 # (you don't need to compile anything for profiling or enable profiling # libraries to get a heap profile). # * view the heap profiles, read off the maximum residency. If it has # really changed, then you know there's an issue. -RESIDENCY_OPTS = '+RTS -A256k -i0 -h -RTS' +RESIDENCY_OPTS = '+RTS -A256k -i0 -hT -RTS' # See Note [Measuring residency]. def collect_runtime_residency(tolerance_pct: float): @@ -1710,7 +1710,7 @@ def simple_run(name: TestName, way: WayName, prog: str, extra_run_opts: str) -> stderr=read_stderr(name), stdout=read_stdout(name)) - check_hp = '-h' in my_rts_flags and opts.check_hp + check_hp = '-hT' in my_rts_flags and opts.check_hp check_prof = '-p' in my_rts_flags # exit_code > 127 probably indicates a crash, so don't try to run hp2ps. |