diff options
| author | Bartosz Nitka <niteria@gmail.com> | 2016-05-04 09:22:37 -0700 |
|---|---|---|
| committer | Bartosz Nitka <niteria@gmail.com> | 2016-05-04 10:18:10 -0700 |
| commit | ad4392c142696d5092533480a82ed65322e9d413 (patch) | |
| tree | 6b7dc893f6dcf0c87db84fef9c29e675a8db8095 /testsuite/tests/ado | |
| parent | 763610e990207eaa143856fca411d5ad420651ed (diff) | |
| download | haskell-ad4392c142696d5092533480a82ed65322e9d413.tar.gz | |
Kill non-deterministic foldUFM in TrieMap and TcAppMap
Summary:
foldUFM introduces unnecessary non-determinism that actually
leads to different generated code as explained in
Note [TrieMap determinism].
As we're switching from UniqFM to UniqDFM here you might be
concerned about performance. There's nothing that ./validate
detects. nofib reports no change in Compile Allocations, but
Compile Time got better on some tests and worse on some,
yielding this summary:
-1 s.d. ----- -3.8%
+1 s.d. ----- +5.4%
Average ----- +0.7%
This is not a fair comparison as the order of Uniques
changes what GHC is actually doing. One benefit from making
this deterministic is also that it will make the
performance results more stable.
Full nofib results: P108
Test Plan: ./validate, nofib
Reviewers: goldfire, simonpj, simonmar, austin, bgamari
Reviewed By: simonpj
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D2169
GHC Trac Issues: #4012
Diffstat (limited to 'testsuite/tests/ado')
| -rw-r--r-- | testsuite/tests/ado/ado004.stderr | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/testsuite/tests/ado/ado004.stderr b/testsuite/tests/ado/ado004.stderr index 6a39e6d142..8f5a816612 100644 --- a/testsuite/tests/ado/ado004.stderr +++ b/testsuite/tests/ado/ado004.stderr @@ -3,11 +3,11 @@ TYPE SIGNATURES forall (f :: * -> *). Applicative f => (Int -> f Int) -> f Int test2 :: forall t b (f :: * -> *). - (Applicative f, Num t, Num b) => + (Num b, Num t, Applicative f) => (t -> f b) -> f b test2a :: forall t b (f :: * -> *). - (Num t, Num b, Functor f) => + (Num b, Num t, Functor f) => (t -> f b) -> f b test2b :: forall (m :: * -> *) a t. (Num t, Monad m) => (t -> a) -> m a |