diff options
| author | Joachim Breitner <mail@joachim-breitner.de> | 2021-10-14 18:57:54 +0200 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2021-10-24 01:27:57 -0400 |
| commit | 3417a81a34fdf74857138a105b2ab4ee32e658c4 (patch) | |
| tree | 22e4f7228512698fa93bc093d463be96f7ad6939 /testsuite/tests/codeGen | |
| parent | 691c450f1e9cc3fd83b662be3c0134fde03e97db (diff) | |
| download | haskell-3417a81a34fdf74857138a105b2ab4ee32e658c4.tar.gz | |
undefined: Neater CallStack in error message
Users of `undefined` don’t want to see
```
files.hs: Prelude.undefined:
CallStack (from HasCallStack):
error, called at libraries/base/GHC/Err.hs:79:14 in base:GHC.Err
undefined, called at file.hs:151:19 in main:Main
```
but want to see
```
files.hs: Prelude.undefined:
CallStack (from HasCallStack):
undefined, called at file.hs:151:19 in main:Main
```
so let’s make that so.
The function for that is `withFrozenCallStack`, but that is not usable
here (module dependencies, and also not representation-polymorphic). And
even if it were, it could confuse GHC’s strictness analyzer, leading to
big regressions in some perf tests (T10421 in particular).
So after shuffling modules and definitions around, I eventually noticed
that the easiest way is to just not call `error` here.
Fixes #19886
Diffstat (limited to 'testsuite/tests/codeGen')
| -rw-r--r-- | testsuite/tests/codeGen/should_run/T16846.stderr | 1 | ||||
| -rw-r--r-- | testsuite/tests/codeGen/should_run/T5626.stderr | 3 |
2 files changed, 1 insertions, 3 deletions
diff --git a/testsuite/tests/codeGen/should_run/T16846.stderr b/testsuite/tests/codeGen/should_run/T16846.stderr index f737c83af0..3d1cbeef10 100644 --- a/testsuite/tests/codeGen/should_run/T16846.stderr +++ b/testsuite/tests/codeGen/should_run/T16846.stderr @@ -1,4 +1,3 @@ T16846: Prelude.undefined CallStack (from HasCallStack): - error, called at libraries/base/GHC/Err.hs:80:14 in base:GHC.Err undefined, called at T16846.hs:22:3 in main:Main diff --git a/testsuite/tests/codeGen/should_run/T5626.stderr b/testsuite/tests/codeGen/should_run/T5626.stderr index 2c02bb0a5c..921c69a8cd 100644 --- a/testsuite/tests/codeGen/should_run/T5626.stderr +++ b/testsuite/tests/codeGen/should_run/T5626.stderr @@ -1,4 +1,3 @@ T5626: Prelude.undefined -CallStack (from ImplicitParams): - error, called at libraries/base/GHC/Err.hs:43:14 in base:GHC.Err +CallStack (from HasCallStack): undefined, called at T5626.hs:6:30 in main:Main |