diff options
| author | Ryan Scott <ryan.gl.scott@gmail.com> | 2017-08-12 15:46:44 -0400 |
|---|---|---|
| committer | Ryan Scott <ryan.gl.scott@gmail.com> | 2017-08-12 15:46:44 -0400 |
| commit | 3f05e5f6becc2f7174898726b6f027105b12a780 (patch) | |
| tree | 54189ff786c9f176db04ab575590f3d2a8514792 /testsuite/tests/deriving/should_fail | |
| parent | a4f347c23ed926c24d178fec54c27d94f1fae0e4 (diff) | |
| download | haskell-3f05e5f6becc2f7174898726b6f027105b12a780.tar.gz | |
Don't suppress unimplemented type family warnings with DeriveAnyClass
Summary:
For some asinine reason, we were suppressing warnings when
deriving associated type family instances with `DeriveAnyClass`. That seems
like a bad idea. Let's not do that.
Along the way, I noticed that the error contexts associated with these
newly emitted warnings were less than ideal, so I did some minor refactoring
to improve the story there.
Fixes #14094
Test Plan: ./validate
Reviewers: bgamari, austin
Subscribers: rwbarton, thomie
GHC Trac Issues: #14094
Differential Revision: https://phabricator.haskell.org/D3828
Diffstat (limited to 'testsuite/tests/deriving/should_fail')
| -rw-r--r-- | testsuite/tests/deriving/should_fail/T10598_fail3.stderr | 7 | ||||
| -rw-r--r-- | testsuite/tests/deriving/should_fail/T8165_fail2.stderr | 7 |
2 files changed, 7 insertions, 7 deletions
diff --git a/testsuite/tests/deriving/should_fail/T10598_fail3.stderr b/testsuite/tests/deriving/should_fail/T10598_fail3.stderr index a987a4993d..c3f4e123b7 100644 --- a/testsuite/tests/deriving/should_fail/T10598_fail3.stderr +++ b/testsuite/tests/deriving/should_fail/T10598_fail3.stderr @@ -1,5 +1,4 @@ -T10598_fail3.hs:1:1: error: - Generic instances can only be derived in Safe Haskell using the stock strategy. - In the following instance: - instance [safe] Generic T +T10598_fail3.hs:8:36: error: + • Generic instances can only be derived in Safe Haskell using the stock strategy. + • In the instance declaration for ‘Generic T’ diff --git a/testsuite/tests/deriving/should_fail/T8165_fail2.stderr b/testsuite/tests/deriving/should_fail/T8165_fail2.stderr index 4c925f52a3..5e19173a33 100644 --- a/testsuite/tests/deriving/should_fail/T8165_fail2.stderr +++ b/testsuite/tests/deriving/should_fail/T8165_fail2.stderr @@ -1,5 +1,6 @@ T8165_fail2.hs:9:12: error: - The type family application ‘T Loop’ - is no smaller than the instance head - (Use UndecidableInstances to permit this) + • The type family application ‘T Loop’ + is no smaller than the instance head + (Use UndecidableInstances to permit this) + • In the instance declaration for ‘C Loop’ |