diff options
| author | Edward Z. Yang <ezyang@cs.stanford.edu> | 2014-11-17 21:23:52 -0800 |
|---|---|---|
| committer | Edward Z. Yang <ezyang@cs.stanford.edu> | 2014-11-29 23:16:31 -0800 |
| commit | 4c834fdddf4d44d12039da4d6a2c63a660975b95 (patch) | |
| tree | 58c18fc03de10b2832ca62655dbba4cd833cec95 /testsuite/tests/driver/Makefile | |
| parent | 46c53d5ce5a1d00f29ffea0c3741d972e4beab97 (diff) | |
| download | haskell-4c834fdddf4d44d12039da4d6a2c63a660975b95.tar.gz | |
Filter instance visibility based on set of visible orphans, fixes #2182.ghc-instvis
Summary:
Amazingly, the fix for this very old bug is quite simple: when type-checking,
maintain a set of "visible orphan modules" based on the orphans list of
modules which we explicitly imported. When we import an instance and it
is an orphan, we check if it is in the visible modules set, and if not,
ignore it. A little bit of refactoring for when orphan-hood is calculated
happens so that we always know if an instance is an orphan or not.
For GHCi, we preinitialize the visible modules set based on the list of
interactive imports which are active.
Future work: Cache the visible orphan modules set for GHCi, rather than
recomputing it every type-checking round. (But it's tricky what to do when you
/remove/ a module: you need a data structure a little more complicated than
just a set of modules.)
Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Test Plan: new tests and validate
Reviewers: simonpj, austin
Subscribers: thomie, carter
Differential Revision: https://phabricator.haskell.org/D488
GHC Trac Issues: #2182
Diffstat (limited to 'testsuite/tests/driver/Makefile')
| -rw-r--r-- | testsuite/tests/driver/Makefile | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/testsuite/tests/driver/Makefile b/testsuite/tests/driver/Makefile index edc78d8845..4670958c91 100644 --- a/testsuite/tests/driver/Makefile +++ b/testsuite/tests/driver/Makefile @@ -569,6 +569,11 @@ T703: "$(TEST_HC)" $(TEST_HC_OPTS) --make T703.hs -v0 ! readelf -W -l T703 2>/dev/null | grep 'GNU_STACK' | grep -q 'RWE' +.PHONY: T2182 +T2182: + ! "$(TEST_HC)" $(TEST_HC_OPTS) --make T2182_A.hs T2182.hs -v0 + ! "$(TEST_HC)" $(TEST_HC_OPTS) --make T2182.hs T2182_A.hs -v0 + .PHONY: write_interface_oneshot write_interface_oneshot: $(RM) -rf write_interface_oneshot/A011.hi |