diff options
| author | Simon Marlow <marlowsd@gmail.com> | 2015-11-07 09:39:05 +0000 |
|---|---|---|
| committer | Simon Marlow <marlowsd@gmail.com> | 2015-11-07 09:39:05 +0000 |
| commit | ce1f1607ed7f8fedd2f63c8610cafefd59baaf32 (patch) | |
| tree | 718641160c3d93a2ca974deec1e228cb09e1a97e /testsuite/tests/ghc-e | |
| parent | a58eeb7febd67c93dab82de7049ef1dcdecd34e9 (diff) | |
| download | haskell-ce1f1607ed7f8fedd2f63c8610cafefd59baaf32.tar.gz | |
Make GHCi & TH work when the compiler is built with -prof
Summary:
Amazingly, there were zero changes to the byte code generator and very
few changes to the interpreter - mainly because we've used good
abstractions that hide the differences between profiling and
non-profiling. So that bit was pleasantly straightforward, but there
were a pile of other wibbles to get the whole test suite through.
Note that a compiler built with -prof is now like one built with
-dynamic, in that to use TH you have to build the code the same way.
For dynamic, we automatically enable -dynamic-too when TH is required,
but we don't have anything equivalent for profiling, so you have to
explicitly use -prof when building code that uses TH with a profiled
compiler. For this reason Cabal won't work with TH. We don't expect
to ship a profiled compiler, so I think that's OK.
Test Plan: validate with GhcProfiled=YES in validate.mk
Reviewers: goldfire, bgamari, rwbarton, austin, hvr, erikd, ezyang
Reviewed By: ezyang
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D1407
GHC Trac Issues: #4837, #545
Diffstat (limited to 'testsuite/tests/ghc-e')
| -rw-r--r-- | testsuite/tests/ghc-e/should_fail/all.T | 2 | ||||
| -rw-r--r-- | testsuite/tests/ghc-e/should_run/all.T | 2 |
2 files changed, 0 insertions, 4 deletions
diff --git a/testsuite/tests/ghc-e/should_fail/all.T b/testsuite/tests/ghc-e/should_fail/all.T index d5400bf713..8cb6d9a68b 100644 --- a/testsuite/tests/ghc-e/should_fail/all.T +++ b/testsuite/tests/ghc-e/should_fail/all.T @@ -1,5 +1,3 @@ -setTestOpts(when(compiler_profiled(), skip)) - test('T7962', [exit_code(2), req_interp, ignore_output], run_command, ['$MAKE --no-print-directory -s T7962']) diff --git a/testsuite/tests/ghc-e/should_run/all.T b/testsuite/tests/ghc-e/should_run/all.T index 0e6f7f9c17..dcb720723d 100644 --- a/testsuite/tests/ghc-e/should_run/all.T +++ b/testsuite/tests/ghc-e/should_run/all.T @@ -1,6 +1,4 @@ -setTestOpts(when(compiler_profiled(), skip)) - test('ghc-e001', req_interp, run_command, ['$MAKE --no-print-directory -s ghc-e001']) test('ghc-e002', req_interp, run_command, ['$MAKE --no-print-directory -s ghc-e002']) test('ghc-e003', req_interp, run_command, ['$MAKE --no-print-directory -s ghc-e003']) |