diff options
| author | Edward Z. Yang <ezyang@cs.stanford.edu> | 2016-10-28 17:54:36 -0700 |
|---|---|---|
| committer | Edward Z. Yang <ezyang@cs.stanford.edu> | 2016-11-16 21:31:59 -0800 |
| commit | 31398fbc6d9ee0bd95de64b08becc38faf188972 (patch) | |
| tree | 0ae632f650671447b96ce231781240b4d840097f /testsuite/tests/module | |
| parent | b76958671cda1df9f6f0e1d54d681144d09cb06e (diff) | |
| download | haskell-31398fbc6d9ee0bd95de64b08becc38faf188972.tar.gz | |
Test for type synonym loops on TyCon.
Summary:
Previously, we tested for type synonym loops by doing
a syntactic test on the literal type synonym declarations.
However, in some cases, loops could go through hs-boot
files, leading to an infinite loop (#12042); a similar
situation can occur when signature merging.
This commit replaces the syntactic test with a test on
TyCon, simply by walking down all type synonyms until
we bottom out, or find we've looped back. It's a lot
simpler.
Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Test Plan: validate
Reviewers: simonpj, austin, bgamari
Subscribers: goldfire, thomie
Differential Revision: https://phabricator.haskell.org/D2656
GHC Trac Issues: #12042
Diffstat (limited to 'testsuite/tests/module')
| -rw-r--r-- | testsuite/tests/module/mod27.stderr | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/testsuite/tests/module/mod27.stderr b/testsuite/tests/module/mod27.stderr index 85848345d5..d2c333ffbf 100644 --- a/testsuite/tests/module/mod27.stderr +++ b/testsuite/tests/module/mod27.stderr @@ -1,5 +1,5 @@ -mod27.hs:3:1: +mod27.hs:3:1: error: Cycle in type synonym declarations: mod27.hs:3:1-18: type T1 = (Int, T2) mod27.hs:4:1-18: type T2 = (Int, T1) |