diff options
| author | Adam Gundry <adam@well-typed.com> | 2022-08-17 20:49:24 +0100 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2022-09-13 10:28:29 -0400 |
| commit | 08f6730cd04ae9cdba30c0e371522ddc9a25b716 (patch) | |
| tree | e5d4402edeb411866293b834b045b78211c9a61b /testsuite/tests/overloadedrecflds | |
| parent | 362cca13858faf7e1158273780ea900e7dad5827 (diff) | |
| download | haskell-08f6730cd04ae9cdba30c0e371522ddc9a25b716.tar.gz | |
Allow imports to reference multiple fields with the same name (#21625)
If a module `M` exports two fields `f` (using DuplicateRecordFields), we can
still accept
import M (f)
import M hiding (f)
and treat `f` as referencing both of them. This was accepted in GHC 9.0, but gave
rise to an ambiguity error in GHC 9.2. See #21625.
This patch also documents this behaviour in the user's guide, and updates the
test for #16745 which is now treated differently.
Diffstat (limited to 'testsuite/tests/overloadedrecflds')
5 files changed, 26 insertions, 12 deletions
diff --git a/testsuite/tests/overloadedrecflds/should_compile/T21625.hs b/testsuite/tests/overloadedrecflds/should_compile/T21625.hs new file mode 100644 index 0000000000..125b16cc27 --- /dev/null +++ b/testsuite/tests/overloadedrecflds/should_compile/T21625.hs @@ -0,0 +1,5 @@ +module T21625 where + +import T21625B hiding (B, f) + +c = C 'x' diff --git a/testsuite/tests/overloadedrecflds/should_compile/T21625B.hs b/testsuite/tests/overloadedrecflds/should_compile/T21625B.hs new file mode 100644 index 0000000000..3e39398f08 --- /dev/null +++ b/testsuite/tests/overloadedrecflds/should_compile/T21625B.hs @@ -0,0 +1,6 @@ +{-# LANGUAGE DuplicateRecordFields #-} + +module T21625B where + +data B = B {f :: Int} +data C = C {f :: Char} diff --git a/testsuite/tests/overloadedrecflds/should_compile/all.T b/testsuite/tests/overloadedrecflds/should_compile/all.T index dd5660b445..fc56b23fab 100644 --- a/testsuite/tests/overloadedrecflds/should_compile/all.T +++ b/testsuite/tests/overloadedrecflds/should_compile/all.T @@ -11,3 +11,4 @@ test('T18999_FieldSelectors', normal, compile, ['']) test('T19154', normal, compile, ['']) test('T20723', normal, compile, ['']) test('T20989', normal, compile, ['']) +test('T21625', [], multimod_compile, ['T21625', '-v0']) diff --git a/testsuite/tests/overloadedrecflds/should_fail/T16745.stderr b/testsuite/tests/overloadedrecflds/should_fail/T16745.stderr index 6e1cac2fbe..61a9567788 100644 --- a/testsuite/tests/overloadedrecflds/should_fail/T16745.stderr +++ b/testsuite/tests/overloadedrecflds/should_fail/T16745.stderr @@ -3,12 +3,12 @@ [3 of 4] Compiling T16745D ( T16745D.hs, T16745D.o ) [4 of 4] Compiling T16745A ( T16745A.hs, T16745A.o ) -T16745A.hs:3:24: error: - Ambiguous name ‘field’ in import item. It could refer to: - T16745C.field - T16745B.R(field) - -T16745A.hs:4:24: error: - Ambiguous name ‘foo’ in import item. It could refer to: - T16745D.T(foo) - T16745D.S(foo) +T16745A.hs:8:9: error: + Ambiguous occurrence ‘field’ + It could refer to + either the field ‘field’ of record ‘T16745B.R’, + imported from ‘T16745B’ at T16745A.hs:3:24-28 + (and originally defined at T16745B.hs:11:14-18) + or ‘T16745B.field’, + imported from ‘T16745B’ at T16745A.hs:3:24-28 + (and originally defined in ‘T16745C’ at T16745C.hs:2:1-5) diff --git a/testsuite/tests/overloadedrecflds/should_fail/T16745A.hs b/testsuite/tests/overloadedrecflds/should_fail/T16745A.hs index 49dbeb3fac..b64d87b6c7 100644 --- a/testsuite/tests/overloadedrecflds/should_fail/T16745A.hs +++ b/testsuite/tests/overloadedrecflds/should_fail/T16745A.hs @@ -1,6 +1,8 @@ module T16745A where -import T16745B hiding (field) -import T16745D hiding (foo) +import T16745B (field) -- imports both 'field's +import T16745D hiding (foo) -- allowed, hides both 'foo' fields -wrong = foo -- should not be in scope +foo = foo + +wrong = field -- ambiguous which 'field' is meant |