diff options
| author | RyanGlScott <ryan.gl.scott@gmail.com> | 2015-12-22 11:25:59 +0100 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2015-12-22 13:22:29 +0100 |
| commit | f975b0b10b2971d00b6e1986e0a2af2bf759a4f4 (patch) | |
| tree | 8b890f6e8058bb0a625a409de70f107101048d8d /testsuite/tests/overloadedrecflds | |
| parent | b407bd775d9241023b4694b3142a756df0082ea2 (diff) | |
| download | haskell-f975b0b10b2971d00b6e1986e0a2af2bf759a4f4.tar.gz | |
Rework Template Haskell's handling of strictness
Currently, Template Haskell's treatment of strictness is not enough to
cover all possible combinations of unpackedness and strictness. In
addition, it isn't equipped to deal with new features (such as
`-XStrictData`) which can change a datatype's fields' strictness during
compilation.
To address this, I replaced TH's `Strict` datatype with
`SourceUnpackedness` and `SourceStrictness` (which give the programmer a
more complete toolkit to configure a datatype field's strictness than
just `IsStrict`, `IsLazy`, and `Unpack`). I also added the ability to
reify a constructor fields' strictness post-compilation through the
`reifyConStrictness` function.
Fixes #10697.
Test Plan: ./validate
Reviewers: simonpj, goldfire, bgamari, austin
Reviewed By: goldfire, bgamari
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D1603
GHC Trac Issues: #10697
Diffstat (limited to 'testsuite/tests/overloadedrecflds')
| -rw-r--r-- | testsuite/tests/overloadedrecflds/should_run/overloadedrecfldsrun04.hs | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/testsuite/tests/overloadedrecflds/should_run/overloadedrecfldsrun04.hs b/testsuite/tests/overloadedrecflds/should_run/overloadedrecfldsrun04.hs index e97fdcea9a..d3c85ba9ec 100644 --- a/testsuite/tests/overloadedrecflds/should_run/overloadedrecfldsrun04.hs +++ b/testsuite/tests/overloadedrecflds/should_run/overloadedrecfldsrun04.hs @@ -7,7 +7,10 @@ import Language.Haskell.TH.Syntax -- Splice in a datatype with field... $(return [DataD [] (mkName "R") [] Nothing - [RecC (mkName "MkR") [(mkName "foo", NotStrict, ConT ''Int)]] []]) + [RecC (mkName "MkR") [( mkName "foo" + , Bang NoSourceUnpackedness NoSourceStrictness + , ConT ''Int + )]] []]) -- New TH story means reify only sees R if we do this: $(return []) |