diff options
| author | Adam Gundry <adam@well-typed.com> | 2020-12-23 22:22:08 +0000 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2021-02-16 04:34:43 -0500 |
| commit | 2521b041bff00458cb2c84b8747ea60d6991e329 (patch) | |
| tree | 091e47028c452050ee46fcb70aa9a01186120c1e /testsuite/tests/patsyn | |
| parent | f422c12d26f183481ad8a833667cbfdd1c9b3e95 (diff) | |
| download | haskell-2521b041bff00458cb2c84b8747ea60d6991e329.tar.gz | |
Implement NoFieldSelectors extension (ghc-proposals 160)
Fixes #5972. This adds an extension NoFieldSelectors to disable the generation
of selector functions corresponding to record fields. When this extension is
enabled, record field selectors are not accessible as functions, but users are
still able to use them for record construction, pattern matching and updates.
See Note [NoFieldSelectors] in GHC.Rename.Env for details.
Defining the same field multiple times requires the DuplicateRecordFields
extension to be enabled, even when NoFieldSelectors is in use.
Along the way, this fixes the use of non-imported DuplicateRecordFields in GHCi
with -fimplicit-import-qualified (fixes #18729).
Moreover, it extends DisambiguateRecordFields to ignore non-fields when looking
up fields in record updates (fixes #18999), as described by
Note [DisambiguateRecordFields for updates].
Co-authored-by: Simon Hafner <hafnersimon@gmail.com>
Co-authored-by: Fumiaki Kinoshita <fumiexcel@gmail.com>
Diffstat (limited to 'testsuite/tests/patsyn')
3 files changed, 18 insertions, 0 deletions
diff --git a/testsuite/tests/patsyn/should_fail/all.T b/testsuite/tests/patsyn/should_fail/all.T index 5faea83c88..9520cc0b77 100644 --- a/testsuite/tests/patsyn/should_fail/all.T +++ b/testsuite/tests/patsyn/should_fail/all.T @@ -16,6 +16,7 @@ test('records-no-uni-update2', normal, compile_fail, ['']) test('records-mixing-fields', normal, compile_fail, ['']) test('records-exquant', normal, compile_fail, ['']) test('records-poly-update', normal, compile_fail, ['']) +test('records-nofieldselectors', normal, compile_fail, ['']) test('mixed-pat-syn-record-sels', normal, compile_fail, ['']) test('T11039', normal, compile_fail, ['']) test('T11039a', normal, compile, ['']) diff --git a/testsuite/tests/patsyn/should_fail/records-nofieldselectors.hs b/testsuite/tests/patsyn/should_fail/records-nofieldselectors.hs new file mode 100644 index 0000000000..17fa340905 --- /dev/null +++ b/testsuite/tests/patsyn/should_fail/records-nofieldselectors.hs @@ -0,0 +1,12 @@ +{-# LANGUAGE NoFieldSelectors #-} +{-# LANGUAGE PatternSynonyms #-} +module ShouldFail where + +pattern Single{x} = [x] + +-- Selector +selector :: Int +selector = x [5] + +update :: [String] +update = ["String"] { x = "updated" } diff --git a/testsuite/tests/patsyn/should_fail/records-nofieldselectors.stderr b/testsuite/tests/patsyn/should_fail/records-nofieldselectors.stderr new file mode 100644 index 0000000000..26124310fc --- /dev/null +++ b/testsuite/tests/patsyn/should_fail/records-nofieldselectors.stderr @@ -0,0 +1,5 @@ + +records-nofieldselectors.hs:9:12: error: + • Variable not in scope: x :: [a0] -> Int + • NB: ‘x’ is a field selector + that has been suppressed by NoFieldSelectors |