diff options
author | Daniel Haraj <dan@obsidian.systems> | 2017-01-31 22:28:55 +0000 |
---|---|---|
committer | Matthew Pickering <matthewtpickering@gmail.com> | 2017-01-31 22:31:03 +0000 |
commit | 748b79741652028827b6225c36b8ab55d22bdeb0 (patch) | |
tree | 100d4c51d4a1a621f3de68a211d7ed047f84e498 /testsuite/tests/perf/should_run/T5835.hs | |
parent | c71f0c4ef931885a6c35d64e803338ba3781ff23 (diff) | |
download | haskell-748b79741652028827b6225c36b8ab55d22bdeb0.tar.gz |
Use top-level instances to solve superclasses where possible
This patch introduces a new flag `-fsolve-constant-dicts` which makes the
constraint solver solve super class constraints with available dictionaries if
possible. The flag is enabled by `-O1`.
The motivation of this patch is that the compiler can produce more efficient
code if the constraint solver used top-level instance declarations to solve
constraints that are currently solved givens and their superclasses. In
particular, as it currently stands, the compiler imposes a performance penalty
on the common use-case where superclasses are bundled together for user
convenience. The performance penalty applies to constraint synonyms as
well. This example illustrates the issue:
```
{-# LANGUAGE ConstraintKinds, MultiParamTypeClasses, FlexibleContexts #-}
module B where
class M a b where m :: a -> b
type C a b = (Num a, M a b)
f :: C Int b => b -> Int -> Int
f _ x = x + 1
```
Output without the patch, notice that we get the instance for `Num Int` by
using the class selector `p1`.
```
f :: forall b_arz. C Int b_arz => b_arz -> Int -> Int
f =
\ (@ b_a1EB) ($d(%,%)_a1EC :: C Int b_a1EB) _ (eta1_B1 :: Int) ->
+ @ Int
(GHC.Classes.$p1(%,%) @ (Num Int) @ (M Int b_a1EB) $d(%,%)_a1EC)
eta1_B1
B.f1
```
Output with the patch, nicely optimised code!
```
f :: forall b. C Int b => b -> Int -> Int
f =
\ (@ b) _ _ (x_azg :: Int) ->
case x_azg of { GHC.Types.I# x1_a1DP ->
GHC.Types.I# (GHC.Prim.+# x1_a1DP 1#)
}
```
Reviewers: simonpj, bgamari, austin
Reviewed By: simonpj
Subscribers: mpickering, rwbarton, thomie
Differential Revision: https://phabricator.haskell.org/D2714
GHC Trac Issues: #12791, #5835
Diffstat (limited to 'testsuite/tests/perf/should_run/T5835.hs')
-rw-r--r-- | testsuite/tests/perf/should_run/T5835.hs | 11 |
1 files changed, 11 insertions, 0 deletions
diff --git a/testsuite/tests/perf/should_run/T5835.hs b/testsuite/tests/perf/should_run/T5835.hs new file mode 100644 index 0000000000..25787cb137 --- /dev/null +++ b/testsuite/tests/perf/should_run/T5835.hs @@ -0,0 +1,11 @@ +{-# LANGUAGE GADTs #-} +module Main where + +data T t a where + T :: (Foldable t, Eq a) => t a -> T t a + +{-# NOINLINE go #-} +go :: T [] a -> Int -> Int +go (T _) i = foldr (+) 0 [1..i] + +main = print (go (T [1::Int]) 20000) |