Minor cleanup

- Remove unused functions exprToCoercion_maybe, applyTypeToArg,
  typeMonoPrimRep_maybe, runtimeRepMonoPrimRep_maybe.
- Replace orValid with a simpler check
- Use splitAtList in applyTysX
- Remove calls to extra_clean in the testsuite; it does not do anything.

Metric Decrease:
    T18223

3 files changed, 4 insertions, 14 deletions

diff --git a/testsuite/tests/perf/compiler/all.T b/testsuite/tests/perf/compiler/all.T
index e424639e7a..5cbe3b6e51 100644
--- a/testsuite/tests/perf/compiler/all.T
+++ b/testsuite/tests/perf/compiler/all.T
@@ -217,8 +217,7 @@ test('T9961',
 
 test('T9233',
     [ only_ways(['normal']),
-      collect_compiler_stats('bytes allocated', 1),
-      extra_clean(['T9233a.hi', 'T9233a.o'])
+      collect_compiler_stats('bytes allocated', 1)
     ],
     multimod_compile,
     ['T9233', '-v0 -O2 -fno-spec-constr'])
@@ -272,7 +271,6 @@ test('T12234',
 test('T12545',
      [ only_ways(['normal']),
        collect_compiler_stats('bytes allocated', 10), #
-       extra_clean(['T12545a.hi', 'T12545a.o'])
      ],
      multimod_compile,
      ['T12545', '-v0'] )
@@ -503,7 +501,6 @@ test('T14683',
 test ('T9630',
       [ collect_compiler_residency(15),
         collect_compiler_stats('bytes allocated', 2),
-        extra_clean(['T9630a.hi', 'T9630a.o']),
       ],
       multimod_compile,
       ['T9630', '-v0 -O'])
@@ -544,7 +541,6 @@ test ('T16473',
 
 test('T17516',
       [ collect_compiler_stats('bytes allocated', 5),
-        extra_clean(['T17516A.hi', 'T17516A.o'])
       ],
       multimod_compile,
       ['T17516', '-O -v0'])
diff --git a/testsuite/tests/perf/should_run/all.T b/testsuite/tests/perf/should_run/all.T
index ca6570f639..eb5124a155 100644
--- a/testsuite/tests/perf/should_run/all.T
+++ b/testsuite/tests/perf/should_run/all.T
@@ -87,8 +87,7 @@ test('T4321',
 
 test('T3736', [], makefile_test, ['T3736'])
 test('T3738',
-     [extra_clean(['T3738a.hi', 'T3738a.o']),
-      collect_runtime_residency(1),
+     [collect_runtime_residency(1),
       collect_stats('bytes allocated',8),
       only_ways(['normal']),
       ],
@@ -106,9 +105,7 @@ test('T2902', [], makefile_test, ['T2902'])
 test('T149',
      [ # expect_broken(149),
        # working (2 Jul 2013, x86-64/Linux)
-      extra_clean(['T149_A',    'T149_B',
-                   'T149_A.hi', 'T149_B.hi',
-                   'T149_A.o',  'T149_B.o'])],
+     ],
      makefile_test, ['T149'])
 
 test('T5113',
@@ -168,7 +165,6 @@ test('T5237',
 
 test('T5536',
      [collect_stats('bytes allocated',1),
-     extra_clean(['T5536.data']),
      ignore_stdout,
      only_ways(['normal'])
      ],
@@ -207,7 +203,6 @@ test('T7436b',
 
 test('T7797',
       [collect_stats('bytes allocated',5),
-      extra_clean(['T7797a.hi', 'T7797a.o']),
       only_ways(['normal'])
       ],
      compile_and_run,
diff --git a/testsuite/tests/perf/space_leaks/all.T b/testsuite/tests/perf/space_leaks/all.T
index f6638555c9..ec8f4dae97 100644
--- a/testsuite/tests/perf/space_leaks/all.T
+++ b/testsuite/tests/perf/space_leaks/all.T
@@ -22,8 +22,7 @@ test('T4334',
 
 test('T2762',
      [collect_runtime_residency(2),
-      only_ways(['normal']),
-      extra_clean(['T2762A.hi', 'T2762A.o'])],
+      only_ways(['normal'])],
      compile_and_run, ['-O'])
 
 test('T4018',