Ditch static flags

This patch converts the 4 lasting static flags (read from the command
line and unsafely stored in immutable global variables) into dynamic
flags. Most use cases have been converted into reading them from a DynFlags.

In cases for which we don't have easy access to a DynFlags, we read from
'unsafeGlobalDynFlags' that is set at the beginning of each 'runGhc'.
It's not perfect (not thread-safe) but it is still better as we can
set/unset these 4 flags before each run when using GHC API.

Updates haddock submodule.

Rebased and finished by: bgamari

Test Plan: validate

Reviewers: goldfire, erikd, hvr, austin, simonmar, bgamari

Reviewed By: simonmar

Subscribers: thomie

Differential Revision: https://phabricator.haskell.org/D2839

GHC Trac Issues: #8440

1 files changed, 5 insertions, 5 deletions

diff --git a/testsuite/tests/plugins/LinkerTicklingPlugin.hs b/testsuite/tests/plugins/LinkerTicklingPlugin.hs
index 52d5e177bb..260d4c1228 100644
--- a/testsuite/tests/plugins/LinkerTicklingPlugin.hs
+++ b/testsuite/tests/plugins/LinkerTicklingPlugin.hs
@@ -1,15 +1,15 @@
 module LinkerTicklingPlugin where
 
 import GhcPlugins
-import StaticFlags
+import DynFlags
 
 plugin :: Plugin
 plugin = defaultPlugin {
         installCoreToDos = install
     }
 
--- This tests whether plugins are linking against the *running* GHC
--- or a new instance of it. If it is a new instance the staticFlags
--- won't have been initialised, so we'll get a GHC panic here:
+-- This tests whether plugins are linking against the *running* GHC or a new
+-- instance of it. If it is a new instance (settings unsafeGlobalDynFlags) won't
+-- have been initialised, so we'll get a GHC panic here:
 install :: [CommandLineOption] -> [CoreToDo] -> CoreM [CoreToDo]
-install _options todos = length staticFlags `seq` return todos
+install _options todos = settings unsafeGlobalDynFlags `seq` return todos