diff options
| author | Ryan Scott <ryan.gl.scott@gmail.com> | 2018-02-18 11:14:26 -0500 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2018-02-18 11:57:46 -0500 |
| commit | 043466b9aac403553e2aaf8054c064016f963f80 (patch) | |
| tree | 766996d96ce3807c3fa9639094b590ca3e3ac498 /testsuite/tests/th/T13123.hs | |
| parent | 7f389a580f42a105623853adad15ab3323b41ed5 (diff) | |
| download | haskell-043466b9aac403553e2aaf8054c064016f963f80.tar.gz | |
Rename the types in a GADT constructor in toposorted order
Previously, we were extracting the free variables from a
GADT constructor in an incorrect order, which caused the type
variables for the constructor's type signature to end up in
non-toposorted order. Thankfully, rearranging the order of types
during renaming makes swift work of this bug.
This fixes a regression introduced in commit
fa29df02a1b0b926afb2525a258172dcbf0ea460.
For whatever reason, that commit also commented out a
significant portion of the `T13123` test. This code appears
to work, so I've opted to uncomment it.
Test Plan: make test TEST=T14808
Reviewers: simonpj, bgamari
Reviewed By: bgamari
Subscribers: rwbarton, thomie, carter
GHC Trac Issues: #14808
Differential Revision: https://phabricator.haskell.org/D4413
Diffstat (limited to 'testsuite/tests/th/T13123.hs')
| -rw-r--r-- | testsuite/tests/th/T13123.hs | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/testsuite/tests/th/T13123.hs b/testsuite/tests/th/T13123.hs index dbc071c184..d7e1006b9e 100644 --- a/testsuite/tests/th/T13123.hs +++ b/testsuite/tests/th/T13123.hs @@ -8,7 +8,6 @@ module T13123 where import GHC.Exts (Constraint) -{- $([d| idProxy :: forall proxy (a :: k). proxy a -> proxy a idProxy x = x |]) @@ -32,7 +31,6 @@ $([d| class Foo b where $([d| data GADT where MkGADT :: forall proxy (a :: k). proxy a -> GADT |]) --} $([d| data Dec13 :: (* -> Constraint) -> * where MkDec13 :: c a => a -> Dec13 c |