diff options
author | Ryan Scott <ryan.gl.scott@gmail.com> | 2018-10-28 16:08:11 -0400 |
---|---|---|
committer | Ben Gamari <ben@smart-cactus.org> | 2018-10-29 15:10:24 -0400 |
commit | b8a797ecc34a309bd78f5a290e3554642a3a478a (patch) | |
tree | 709eb34845e0df4ddea48d4626132e9a0c300522 /testsuite/tests/th/all.T | |
parent | 331081b03f67c94b908136339aebf36d07d45c21 (diff) | |
download | haskell-b8a797ecc34a309bd78f5a290e3554642a3a478a.tar.gz |
Fix #15815 by parenthesizing the arguments to infix ~
An unfortunate consequence of commit
b9483981d128f55d8dae3f434f49fa6b5b30c779 (`Remove HsEqTy and XEqTy`)
is infix uses of `~` in TH quotes now desugar differently than
before. In particular, we have that:
```haskell
a ~ (Int -> Int)
```
Now desugars to:
```haskell
HsOpTy a (~) (HsOpTy Int (->) Int)
```
Which GHC interprets as being:
```haskell
a ~ Int -> Int
```
Or, equivalently:
```haskell
(a ~ Int) -> Int
```
Which is different than what was intended! This is the cause
of #15815.
All of this has revealed that we likely need to renovate the way we
desugar infix type operators to be more consistent with the treatment
for infix expressions (see
https://ghc.haskell.org/trac/ghc/ticket/15815#comment:5 for more on
this.) Doing so would constitute a breaking change, however, so we
will likely want to wait until another major GHC release to do this.
In the meantime, this patch offers a non-invasive change to the way
that infix uses of `~` are desugared. This makes the program
in #15815 compile again by inserting extra `HsParTy`s around the
arguments to `~` if they are lacking them.
Test Plan: make test TEST=T15815
Reviewers: int-index, goldfire, bgamari
Reviewed By: int-index
Subscribers: int-e, rwbarton, carter
GHC Trac Issues: #15815
Differential Revision: https://phabricator.haskell.org/D5274
Diffstat (limited to 'testsuite/tests/th/all.T')
-rw-r--r-- | testsuite/tests/th/all.T | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/testsuite/tests/th/all.T b/testsuite/tests/th/all.T index 50154a4fea..2481a2ab12 100644 --- a/testsuite/tests/th/all.T +++ b/testsuite/tests/th/all.T @@ -446,3 +446,5 @@ test('T15738', normal, compile, ['-v0 -ddump-splices -dsuppress-uniques']) test('T15783', normal, multimod_compile, ['T15783A', '-v0 ' + config.ghc_th_way_flags]) test('T15792', normal, compile, ['-v0 -dsuppress-uniques']) +test('T15815', normal, multimod_compile, + ['T15815B', '-v0 ' + config.ghc_th_way_flags]) |