Remove clean_cmd and extra_clean usage from .T files

The `clean_cmd` and `extra_clean` setup functions don't do anything.
Remove them from .T files.

Created using https://github.com/thomie/refactor-ghc-testsuite. This
diff is a test for the .T-file parser/processor/pretty-printer in that
repository.

    find . -name '*.T' -exec ~/refactor-ghc-testsuite/Main "{}" \;

Tests containing inline comments or multiline strings are not modified.

Preparation for #12223.

Test Plan: Harbormaster

Reviewers: austin, hvr, simonmar, mpickering, bgamari

Reviewed By: mpickering

Subscribers: mpickering

Differential Revision: https://phabricator.haskell.org/D3000

GHC Trac Issues: #12223

1 files changed, 17 insertions, 52 deletions

diff --git a/testsuite/tests/typecheck/should_compile/all.T b/testsuite/tests/typecheck/should_compile/all.T
index d322cc0e00..ccebf75765 100644
--- a/testsuite/tests/typecheck/should_compile/all.T
+++ b/testsuite/tests/typecheck/should_compile/all.T
@@ -171,19 +171,13 @@ test('tc167', normal, compile_fail, [''])
 test('tc168', normal, compile_fail, [''])
 test('tc169', normal, compile, [''])
 
-test('tc170',
-     extra_clean(['Tc170_Aux.hi', 'Tc170_Aux.o']),
-     run_command,
-     ['$MAKE -s --no-print-directory tc170'])
+test('tc170', [], run_command, ['$MAKE -s --no-print-directory tc170'])
 
 test('tc171', normal, compile, [''])
 test('tc172', normal, compile, [''])
 
 # The point about this test is that it compiles Tc173a and Tc173b *separately*
-test('tc173',
-     extra_clean(['Tc173a.hi', 'Tc173a.o', 'Tc173b.hi', 'Tc173b.o']),
-     run_command,
-     ['$MAKE -s --no-print-directory tc173'])
+test('tc173', [], run_command, ['$MAKE -s --no-print-directory tc173'])
 
 test('tc174', normal, compile, [''])
 test('tc175', normal, compile, [''])
@@ -254,18 +248,14 @@ test('tc236', normal, compile, [''])
 test('tc237', normal, compile, [''])
 test('tc238', normal, compile, [''])
 
-test('tc239', extra_clean(['Tc239_Help.hi', 'Tc239_Help.o']),
-     multimod_compile, ['tc239', '-v0'])
+test('tc239', [], multimod_compile, ['tc239', '-v0'])
 
 test('tc240', normal, compile, [''])
 test('tc241', normal, compile, [''])
 test('tc242', normal, compile, [''])
 test('tc243', normal, compile, [''])
 test('tc244', normal, compile, [''])
-test('tc245',
-     extra_clean(['Tc245_A.hi', 'Tc245_A.o', 'tc245.hi', 'tc245.o']),
-     run_command,
-     ['$MAKE -s --no-print-directory tc245'])
+test('tc245', [], run_command, ['$MAKE -s --no-print-directory tc245'])
 test('tc246', normal, compile, [''])
 test('tc247', normal, compile, [''])
 test('tc248', normal, compile, [''])
@@ -279,8 +269,7 @@ test('faxen', normal, compile, [''])
 test('T1495', normal, compile, [''])
 test('T2045', normal, compile, [''])   # Needs -fhpc
 test('T2478', normal, compile, [''])
-test('T2433', extra_clean(['T2433_Help.hi', 'T2433_Help.o']),
-     multimod_compile, ['T2433', '-v0'])
+test('T2433', [], multimod_compile, ['T2433', '-v0'])
 test('T2494', normal, compile_fail, [''])
 test('T2494-2', normal, compile, [''])
 test('T2497', normal, compile, [''])
@@ -306,12 +295,7 @@ test('T3955', normal, compile, [''])
 test('PolyRec', normal, compile, [''])
 test('twins', normal, compile, [''])
 
-test('T2412',
-     extra_clean(['T2412.hi-boot', 'T2412.o-boot',
-                  'T2412A.hi', 'T2412A.o',
-                  'T2412.hi', 'T2412.o']),
-     run_command,
-     ['$MAKE --no-print-directory -s T2412'])
+test('T2412', [], run_command, ['$MAKE --no-print-directory -s T2412'])
 
 test('T2846', normal, compile, [''])
 test('T4284', normal, compile, [''])
@@ -332,8 +316,7 @@ test('T4498', normal, compile, [''])
 test('T4524', normal, compile, [''])
 test('T4917', normal, compile, [''])
 
-test('T4912', extra_clean(['T4912a.hi', 'T4912a.o']),
-     multimod_compile, ['T4912', '-v0'])
+test('T4912', [], multimod_compile, ['T4912', '-v0'])
 
 test('T4952', normal, compile, [''])
 test('T4969', normal, compile, [''])
@@ -341,8 +324,7 @@ test('T5120', normal, compile, [''])
 test('mc18', normal, compile, [''])
 test('tc249', normal, compile, [''])
 test('tc250', normal, compile, [''])
-test('tc251', extra_clean(['Tc251_Help.hi', 'Tc251_Help.o']),
-              multi_compile, ['tc251', [('Tc251_Help.hs', '')], '-v0'])
+test('tc251', [], multi_compile, ['tc251', [('Tc251_Help.hs', '')], '-v0'])
 test('tc252', normal, compile, [''])
 test('tc253', normal, compile, [''])
 test('tc254', normal, compile, [''])
@@ -354,18 +336,10 @@ test('tc259', normal, compile, [''])
 test('tc260', normal, compile, [''])
 test('tc261', normal, compile, [''])
 test('tc262', normal, compile, [''])
-test('tc263',
-    extra_clean(['Tc263_Help.o','Tc263_Help.hi']),
-    multimod_compile, ['tc263','-v0'])
+test('tc263', [], multimod_compile, ['tc263', '-v0'])
 test('tc265', compile_timeout_multiplier(0.01), compile, [''])
-test('tc266',
-     [extra_clean(['Tc266.hi-boot', 'Tc266.o-boot', 'Tc266a.hi', 'Tc266a.o', 'Tc266.hi', 'Tc266.o'])] ,
-     run_command,
-     ['$MAKE -s --no-print-directory tc266'])
-test('Tc267',
-     extra_clean(['Tc267a.hi-boot', 'Tc267a.o-boot', 'Tc267b.hi-boot', 'Tc267b.o-boot', 'Tc267a.hi', 'Tc267a.o', 'Tc267b.hi', 'Tc267b.o']),
-     run_command,
-     ['$MAKE -s --no-print-directory Tc267'])
+test('tc266', [], run_command, ['$MAKE -s --no-print-directory tc266'])
+test('Tc267', [], run_command, ['$MAKE -s --no-print-directory Tc267'])
 test('tc268', normal, compile, [''])
 test('tc269', normal, compile, [''])
 test('tc270', normal, compile, [''])
@@ -397,9 +371,7 @@ test('DfltProb1', normal, compile, ['-O'])
 # Add -O for DfltProb1 to expose Trac #11291
 test('DfltProb2', normal, compile, [''])
 test('T6134', normal, compile, [''])
-test('T6018', extra_clean(['T6018.hi' , 'T6018.o'
-                          ,'T6018A.hi', 'T6018A.o'])
-            , multimod_compile, ['T6018', ''])
+test('T6018', [], multimod_compile, ['T6018', ''])
 test('TcLambdaCase', [], compile, [''])
 test('T7147', normal, compile, [''])
 test('T7171',normal,run_command,
@@ -498,19 +470,14 @@ test('T10770a', expect_broken(10770), compile, [''])
 test('T10770b', expect_broken(10770), compile, [''])
 test('T10935', normal, compile, [''])
 test('T10971a', normal, compile, [''])
-test('T11062', extra_clean(['T11062.hi-boot', 'T11062.o-boot', 'T11062a.hi', 'T11062a.o']),
-     multimod_compile, ['T11062', '-v0'])
+test('T11062', [], multimod_compile, ['T11062', '-v0'])
 test('T11237', normal, compile, [''])
 test('T10592', normal, compile, [''])
 test('T11305', normal, compile, [''])
 test('T11254', normal, compile, [''])
 test('T11379', normal, compile, [''])
-test('T11462',
-     [extra_clean(['T11462_Plugin.hi', 'T11462_Plugin.o']),
-      unless(have_dynamic(), expect_broken(10301))],
-     multi_compile,
-     ['', [('T11462_Plugin.hs', '-package ghc'),
-           ('T11462.hs', '')],
+test('T11462', [unless(have_dynamic(), expect_broken(10301))], multi_compile,
+     ['', [('T11462_Plugin.hs', '-package ghc'), ('T11462.hs', '')],
       '-dynamic'])
 test('T11480', normal, compile, [''])
 test('RebindHR', normal, compile, [''])
@@ -530,8 +497,7 @@ test('T11811', normal, compile, [''])
 test('T11793', normal, compile, [''])
 test('T11348', normal, compile, [''])
 test('T11947', normal, compile, [''])
-test('T12064', extra_clean(['T12064.hi-boot', 'T12064.o-boot', 'T11062a.hi', 'T11062a.o']),
-     multimod_compile, ['T12064', '-v0'])
+test('T12064', [], multimod_compile, ['T12064', '-v0'])
 test('ExPat', normal, compile, [''])
 test('ExPatFail', normal, compile_fail, [''])
 test('SigTyVars', normal, compile, [''])
@@ -542,8 +508,7 @@ test('T11339b', normal, compile, [''])
 test('T11339c', normal, compile, [''])
 test('T11339d', normal, compile, [''])
 test('T11974', normal, compile, [''])
-test('T12067', extra_clean(['T12067a.hi', 'T12067a.o']),
-     multimod_compile, ['T12067', '-v0'])
+test('T12067', [], multimod_compile, ['T12067', '-v0'])
 test('T12185', normal, compile, [''])
 test('T12133', normal, compile, [''])
 test('T12381', normal, compile, [''])