diff options
| author | Ben Gamari <bgamari.foss@gmail.com> | 2015-12-15 16:08:52 +0100 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2015-12-15 20:45:59 +0100 |
| commit | e2c917381ff099820b1ee30fcfa8bc0c20cf5c1f (patch) | |
| tree | f9295bd3f9ab1e4d4b296960d1f046d1eb37b449 /testsuite/tests/wcompat-warnings | |
| parent | 947e44feebb4e979d7d476ff2aa5c7054a1c0899 (diff) | |
| download | haskell-e2c917381ff099820b1ee30fcfa8bc0c20cf5c1f.tar.gz | |
Narrow scope of special-case for unqualified printing of names in core libraries
Commit 547c597112954353cef7157cb0a389bc4f6303eb modifies the
pretty-printer to render names from a set of core packages (`base`,
`ghc-prim`, `template-haskell`) as unqualified. The idea here was that
many of these names typically are not in scope but are well-known by the
user and therefore qualification merely introduces noise.
This, however, is a very large hammer and potentially breaks any
consumer who relies on parsing GHC output (hence #11208). This commit
partially reverts this change, now only printing `Constraint` (which
appears quite often in errors) as unqualified.
Fixes #11208.
Updates tests in `array` submodule.
Test Plan: validate
Reviewers: hvr, thomie, austin
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D1619
GHC Trac Issues: #11208
Diffstat (limited to 'testsuite/tests/wcompat-warnings')
| -rw-r--r-- | testsuite/tests/wcompat-warnings/WCompatWarningsOn.stderr | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/testsuite/tests/wcompat-warnings/WCompatWarningsOn.stderr b/testsuite/tests/wcompat-warnings/WCompatWarningsOn.stderr index 5de8745544..ee2ded8516 100644 --- a/testsuite/tests/wcompat-warnings/WCompatWarningsOn.stderr +++ b/testsuite/tests/wcompat-warnings/WCompatWarningsOn.stderr @@ -1,6 +1,6 @@ WCompatWarningsOn.hs:13:5: warning: - • Could not deduce (MonadFail m) + • Could not deduce (Control.Monad.Fail.MonadFail m) arising from the failable pattern ‘Just _’ (this will become an error a future GHC release) from the context: Monad m @@ -8,7 +8,7 @@ WCompatWarningsOn.hs:13:5: warning: monadFail :: Monad m => m a at WCompatWarningsOn.hs:11:1-27 Possible fix: - add (MonadFail m) to the context of + add (Control.Monad.Fail.MonadFail m) to the context of the type signature for: monadFail :: Monad m => m a • In a stmt of a 'do' block: Just _ <- undefined @@ -26,7 +26,7 @@ WCompatWarningsOn.hs:16:1: warning: WCompatWarningsOn.hs:22:3: warning: Noncanonical ‘(<>) = mappend’ definition detected - in the instance declaration for ‘Semigroup S’. + in the instance declaration for ‘Semi.Semigroup S’. Move definition from ‘mappend’ to ‘(<>)’ WCompatWarningsOn.hs:25:3: warning: |