diff options
| author | Tobias Dammers <tdammers@gmail.com> | 2018-05-14 08:50:29 -0400 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2018-05-14 09:25:19 -0400 |
| commit | d92c7556501a4cdeb7d269c4624992c94d9b3b8b (patch) | |
| tree | 1b477d184aa01823ae6dfe0220ceb258eb5bf055 /testsuite/tests | |
| parent | 1e2720949a406f45b807fad69e7409777607f275 (diff) | |
| download | haskell-d92c7556501a4cdeb7d269c4624992c94d9b3b8b.tar.gz | |
Fix performance regressions from #14737
See #15019. When removing an unnecessary type equality check in #14737,
several regression tests failed. The cause was that some coercions that
are actually Refl coercions weren't passed in as such, which made the
equality check needlessly complex (Refl coercions can be discarded in
this particular check immediately, without inspecting the types at all).
We fix that, and get additional performance improvements for free.
Reviewers: goldfire, bgamari, simonpj
Reviewed By: bgamari, simonpj
Subscribers: simonpj, thomie, carter
Differential Revision: https://phabricator.haskell.org/D4635
Diffstat (limited to 'testsuite/tests')
| -rw-r--r-- | testsuite/tests/perf/compiler/all.T | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/testsuite/tests/perf/compiler/all.T b/testsuite/tests/perf/compiler/all.T index 02668cf8d5..3647b8abf3 100644 --- a/testsuite/tests/perf/compiler/all.T +++ b/testsuite/tests/perf/compiler/all.T @@ -1051,6 +1051,7 @@ test('T12425', # 2017-04-28: 127500136 Remove exponential behaviour in simplifier # 2017-05-23: 134780272 Addition of llvm-targets in dynflags (D3352) # 2018-04-15: 141952368 Collateral of #14737 + # 2018-04-30: 130646336 improved simplCast performance #15019 # 2018-04-26: 150743648 Do not unpack class dictionaries with INLINABLE ]), ], @@ -1122,7 +1123,7 @@ test('T13056', test('T12707', [ compiler_stats_num_field('bytes allocated', - [(wordsize(64), 1237898376, 5), + [(wordsize(64), 1141555816, 5), # initial: 1271577192 # 2017-01-22: 1348865648 Allow top-level strings in Core # 2017-01-31: 1280336112 Join points (#12988) @@ -1131,6 +1132,7 @@ test('T12707', # 2017-03-02: 1231809592 Drift from recent simplifier improvements # 2017-05-14: 1163821528 (amd64/Linux) Two-pass CmmLayoutStack # 2018-04-09: 1237898376 Inexplicable, collateral of #14737 + # 2018-04-30: 1141555816 improved simplCast performance #15019 ]), ], compile, |