diff options
| author | Thomas Miedema <thomasmiedema@gmail.com> | 2016-02-19 15:25:40 +0100 |
|---|---|---|
| committer | Thomas Miedema <thomasmiedema@gmail.com> | 2016-02-19 15:32:38 +0100 |
| commit | d738e66450ec09f69211330df05e381bfe996c13 (patch) | |
| tree | fb2623e190bab970f13eaee3a96b9bd8515768b0 /testsuite/tests | |
| parent | 2f733b3a4b95a35dfdd43915afec9f0f615edacd (diff) | |
| download | haskell-d738e66450ec09f69211330df05e381bfe996c13.tar.gz | |
Modifier letter in middle of identifier is ok
Refactoring only. Cleanup some loose ends from #10196.
Initially the idea was to only allow modifier letters at the end of
identifiers. Since we later decided to allow modifier letters also in
the middle of identifiers (because not doing so would not fix the
regression completely), the names `suffix` and `okIdSuffixChar` don't
seem appropriate anymore.
Remove TODO. Move test from should_fail to should_compile.
Diffstat (limited to 'testsuite/tests')
4 files changed, 5 insertions, 9 deletions
diff --git a/testsuite/tests/parser/should_compile/T10196.hs b/testsuite/tests/parser/should_compile/T10196.hs index f80911829b..a29f0c3a08 100644 --- a/testsuite/tests/parser/should_compile/T10196.hs +++ b/testsuite/tests/parser/should_compile/T10196.hs @@ -11,3 +11,8 @@ f = xᵪ = xᵢ xᵣ = xᵪ in xᵣ + +-- Modifier letters are also allowed in the middle of an identifier. +-- This should not be lexed as 2 separate identifiers. +xᵦx :: Int +xᵦx = 1 diff --git a/testsuite/tests/parser/should_fail/T10196Fail3.hs b/testsuite/tests/parser/should_fail/T10196Fail3.hs deleted file mode 100644 index 09b80ddeff..0000000000 --- a/testsuite/tests/parser/should_fail/T10196Fail3.hs +++ /dev/null @@ -1,6 +0,0 @@ -module T10196Fail3 where - --- Modifier letters are not allowed in the middle of an identifier. --- And this should not be lexed as 2 separate identifiers either. -xᵦx :: Int -xᵦx = 1 diff --git a/testsuite/tests/parser/should_fail/T10196Fail3.stderr b/testsuite/tests/parser/should_fail/T10196Fail3.stderr deleted file mode 100644 index 64037440e2..0000000000 --- a/testsuite/tests/parser/should_fail/T10196Fail3.stderr +++ /dev/null @@ -1,2 +0,0 @@ - -T10196Fail3.hs:5:2: error: lexical error at character '/7526' diff --git a/testsuite/tests/parser/should_fail/all.T b/testsuite/tests/parser/should_fail/all.T index 21b523ad24..e6c6f41db7 100644 --- a/testsuite/tests/parser/should_fail/all.T +++ b/testsuite/tests/parser/should_fail/all.T @@ -91,6 +91,5 @@ test('T8506', normal, compile_fail, ['']) test('T9225', normal, compile_fail, ['']) test('T10196Fail1', normal, compile_fail, ['']) test('T10196Fail2', normal, compile_fail, ['']) -test('T10196Fail3', expect_broken(10196), compile_fail, ['']) test('T10498a', normal, compile_fail, ['']) test('T10498b', normal, compile_fail, ['']) |