diff options
| author | John Ericson <git@JohnEricson.me> | 2020-01-25 15:46:07 -0500 |
|---|---|---|
| committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2020-04-23 18:32:43 -0400 |
| commit | c42754d5fdd3c2db554d9541bab22d1b3def4be7 (patch) | |
| tree | eea28083a89e73b8e08a0d2387eaff19ecf05f13 /testsuite/tests | |
| parent | 5946c85abcf66555cdbcd3eed02cb8f512b6110c (diff) | |
| download | haskell-c42754d5fdd3c2db554d9541bab22d1b3def4be7.tar.gz | |
Trees That Grow refactor for `ConPat` and `CoPat`
- `ConPat{In,Out}` -> `ConPat`
- `CoPat` -> `XPat (CoPat ..)`
Note that `GHC.HS.*` still uses `HsWrap`, but only when `p ~ GhcTc`.
After this change, moving the type family instances out of `GHC.HS.*` is
sufficient to break the cycle.
Add XCollectPat class to decide how binders are collected from XXPat based on the pass.
Previously we did this with IsPass, but that doesn't work for Haddock's
DocNameI, and the constraint doesn't express what actual distinction is being
made. Perhaps a class for collecting binders more generally is in order, but we
haven't attempted this yet.
Pure refactor of code around ConPat
- InPat/OutPat synonyms removed
- rename several identifiers
- redundant constraints removed
- move extension field in ConPat to be first
- make ConPat use record syntax more consistently
Fix T6145 (ConPatIn became ConPat)
Add comments from SPJ.
Add comment about haddock's use of CollectPass.
Updates haddock submodule.
Diffstat (limited to 'testsuite/tests')
| -rw-r--r-- | testsuite/tests/ghc-api/T6145.hs | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/testsuite/tests/ghc-api/T6145.hs b/testsuite/tests/ghc-api/T6145.hs index 3a0d4ff0fb..56538e11d6 100644 --- a/testsuite/tests/ghc-api/T6145.hs +++ b/testsuite/tests/ghc-api/T6145.hs @@ -39,7 +39,7 @@ main = do = not (isEmptyBag (filterBag isDataCon bs)) isDataCon (L l (f@FunBind {})) | (MG _ (L _ (m:_)) _) <- fun_matches f, - ((L _ (c@ConPatOut{})):_)<-hsLMatchPats m, + ((L _ (c@ConPat{})):_)<-hsLMatchPats m, (L l _)<-pat_con c = isGoodSrcSpan l -- Check that the source location is a good one isDataCon _ |