diff options
| author | Edward Z. Yang <ezyang@cs.stanford.edu> | 2014-08-07 14:15:13 +0100 |
|---|---|---|
| committer | Edward Z. Yang <ezyang@cs.stanford.edu> | 2014-08-07 14:15:13 +0100 |
| commit | d026e9e889f347a86425c34b61bfb443a409d1e3 (patch) | |
| tree | 03c18113fc33a23532ff0df0acfe44eda46627c6 /testsuite | |
| parent | 4855be0d0d1ac90f836a6fb54f4034f478e38fd8 (diff) | |
| download | haskell-d026e9e889f347a86425c34b61bfb443a409d1e3.tar.gz | |
Permanently accept the Haddock performance number bump, and add some TODOs
I bisected the performance difference in Haddock and found it was due to
d6aec63c009c4e57181900eb03847d7dc0fc3c7c, which I accidentally picked up
when updating Haddock 00b8f8c5b378fc679639ebe81238cf42d92aa607. The
performance regression is justified by the fact that we are now actually
processing URLs in Haddock comments that we were not previously, so
there would be more allocation. Time use was not affected.
The TODOs simply reflect the fact that we need updated numbers for
32-bit Linux and Windows. Please add them when you get a chance.
Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Diffstat (limited to 'testsuite')
| -rw-r--r-- | testsuite/tests/perf/haddock/all.T | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/testsuite/tests/perf/haddock/all.T b/testsuite/tests/perf/haddock/all.T index 376a944940..dbd24715ff 100644 --- a/testsuite/tests/perf/haddock/all.T +++ b/testsuite/tests/perf/haddock/all.T @@ -44,19 +44,19 @@ test('haddock.base', # 2013-11-21: 6756213256 (x86_64/Linux) # 2014-01-12: 7128342344 (x86_64/Linux) # 2014-06-12: 7498123680 (x86_64/Linux) - # XXX This one is TEMPORARY, it's due to an unoptimized error-path - # that Haddock is tickling, I am profiling and fixing this. - # 2014-08-05: 7992757384 (x86_64/Linux) + # 2014-08-05: 7992757384 (x86_64/Linux - bugfix for #314, Haddock now parses more URLs) ,(platform('i386-unknown-mingw32'), 3548581572, 5) # 2013-02-10: 3358693084 (x86/Windows) # 2013-11-13: 3097751052 (x86/Windows, 64bit machine) # 2014-04-04: 3548581572 (x86/Windows, 64bit machine) + # 2014-08-05: XXX TODO UPDATE ME XXX ,(wordsize(32), 3799130400, 1)]) # 2012-08-14: 3046487920 (x86/OSX) # 2012-10-30: 2955470952 (x86/Windows) # 2013-02-10: 3146596848 (x86/OSX) # 2014-02-22: 3554624600 (x86/Linux - new haddock) # 2014-06-29: 3799130400 (x86/Linux) + # 2014-08-05: XXX TODO UPDATE ME XXX ], stats, ['../../../../libraries/base/dist-install/doc/html/base/base.haddock.t']) @@ -114,18 +114,18 @@ test('haddock.Cabal', # 2013-12-12: 3828567272 (amd64/Linux) # 2014-01-12: 3979151552 (amd64/Linux) new parser # 2014-06-29: 4200993768 (amd64/Linux) - # XXX This one is TEMPORARY, it's due to an unoptimized error-path - # that Haddock is tickling, I am profiling and fixing this. - # 2014-08-05: 4493770224 (x86_64/Linux) + # 2014-08-05: 4493770224 (x86_64/Linux - bugfix for #314, Haddock now parses more URLs) ,(platform('i386-unknown-mingw32'), 2052220292, 5) # 2012-10-30: 1733638168 (x86/Windows) # 2013-02-10: 1906532680 (x86/Windows) # 2014-01-28: 1966911336 (x86/Windows) # 2014-04-24: 2052220292 (x86/Windows) + # 2014-08-05: XXX TODO UPDATE ME XXX ,(wordsize(32), 2127198484, 1)]) # 2012-08-14: 1648610180 (x86/OSX) # 2014-01-22: 1986290624 (x86/Linux) # 2014-06-29: 2127198484 (x86/Linux) + # 2014-08-05: XXX TODO UPDATE ME XXX ], stats, ['../../../../libraries/Cabal/Cabal/dist-install/doc/html/Cabal/Cabal.haddock.t']) |