diff options
| author | Bartosz Nitka <niteria@gmail.com> | 2017-06-27 12:55:17 -0400 |
|---|---|---|
| committer | Ben Gamari <ben@smart-cactus.org> | 2017-06-27 13:34:05 -0400 |
| commit | b0708588e87554899c2efc80a2d3eba353dbe926 (patch) | |
| tree | 03817b07a5c542a45d6058cf19a09efeaf5037bc /utils/check-api-annotations | |
| parent | 6567c815135e93f8550d526f81d13f31c0cd92b6 (diff) | |
| download | haskell-b0708588e87554899c2efc80a2d3eba353dbe926.tar.gz | |
Make module membership on ModuleGraph faster
When loading/reloading with a large number of modules
(>5000) the cost of linear lookups becomes significant.
The changes here made `:reload` go from 6s to 1s on my
test case.
The bottlenecks were `needsLinker` in `DriverPipeline` and
`getModLoop` in `GhcMake`.
Test Plan: ./validate
Reviewers: simonmar, austin, bgamari
Subscribers: rwbarton, thomie
Differential Revision: https://phabricator.haskell.org/D3646
Diffstat (limited to 'utils/check-api-annotations')
| -rw-r--r-- | utils/check-api-annotations/Main.hs | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/utils/check-api-annotations/Main.hs b/utils/check-api-annotations/Main.hs index 1d577421fb..6b973e12e8 100644 --- a/utils/check-api-annotations/Main.hs +++ b/utils/check-api-annotations/Main.hs @@ -32,11 +32,11 @@ testOneFile libdir fileName = do , targetContents = Nothing } _ <- load LoadAllTargets graph <- getModuleGraph - let - modSum = case filter modByFile graph of - [x] -> x - xs -> error $ "Can't find module, got:" - ++ show (map (ml_hs_file . ms_location) xs) + let modSum = + case filter modByFile (mgModSummaries graph) of + [x] -> x + xs -> error $ "Can't find module, got:" + ++ show (map (ml_hs_file . ms_location) xs) p <- parseModule modSum return (pm_annotations p,p) |