diff options
author | Alec Theriault <alec.theriault@gmail.com> | 2018-01-26 13:05:31 -0500 |
---|---|---|
committer | Ben Gamari <ben@smart-cactus.org> | 2018-01-26 14:37:21 -0500 |
commit | 66961dc85e39bbc43a1c065ee00c381a7ee579e1 (patch) | |
tree | f9edaf2e6d5473a9cfcb4ce16d0de3e65456f817 /utils/haddock | |
parent | 983e491927a461457cc587197ce1644746db894b (diff) | |
download | haskell-66961dc85e39bbc43a1c065ee00c381a7ee579e1.tar.gz |
Haddock needs to pass visible modules for instance filtering
The GHC-side `getNameToInstancesIndex` filters out incorrectly some
instances because it is not aware of what modules are visible. Using
`runTcInteractive` means that `ie_visible` gets initialized to a one
module set containing some dummy GHCi module. This is clearly not the
module set we want to check against to see if a given orphan instance
is visible or not.
In fact, GHC has no way of knowing what we want that module set to be
since it doesn't know ahead of time which modules Haddock is making its
docs for. The fix is just to pass that set in as an argument.
Bumps haddock submodule.
Reviewers: bgamari
Reviewed By: bgamari
Subscribers: duog, alexbiehl, rwbarton, thomie, carter
Differential Revision: https://phabricator.haskell.org/D4290
Diffstat (limited to 'utils/haddock')
m--------- | utils/haddock | 0 |
1 files changed, 0 insertions, 0 deletions
diff --git a/utils/haddock b/utils/haddock -Subproject 24841386cff6fdccc11accf9daa815c2c7444d6 +Subproject dd80ae1773ea6aae48c3c5a899d510699783d6e |