diff options
author | Manav Rathi <mx4492@gmail.com> | 2016-02-25 14:51:32 +0100 |
---|---|---|
committer | Ben Gamari <ben@smart-cactus.org> | 2016-02-25 15:41:55 +0100 |
commit | 665849142bca36c14bcb25d64180c153a1ef1f2c (patch) | |
tree | 64d4787d0e2af14ed57d637aaced6cc54a167571 /utils/mkUserGuidePart | |
parent | 673efccb3b348e9daf23d9e65460691bbea8586e (diff) | |
download | haskell-665849142bca36c14bcb25d64180c153a1ef1f2c.tar.gz |
Make warning names more consistent
- Replace "Sigs" with "Signatures" in WarningFlag data constructors.
- Replace "PatSyn" with "PatternSynonym" in WarningFlag data
constructors.
- Deprecate "missing-local-sigs" in favor of "missing-local-signatures".
- Deprecate "missing-exported-sigs" in favor of
"missing-exported-signatures".
- Deprecate "missing-pat-syn-signatures" in favor of
"missing-pattern-synonym-signatures".
- Replace "ddump-strsigs" with "ddump-str-signatures"
These complete the tasks that were explicitly mentioned in #11583
Test Plan:
Executed `ghc --show-options` and verified that the flags were changed
as expected.
Reviewers: svenpanne, austin, bgamari
Reviewed By: austin, bgamari
Subscribers: mpickering, thomie
Differential Revision: https://phabricator.haskell.org/D1939
GHC Trac Issues: #11583
Diffstat (limited to 'utils/mkUserGuidePart')
-rw-r--r-- | utils/mkUserGuidePart/Options/CompilerDebugging.hs | 2 | ||||
-rw-r--r-- | utils/mkUserGuidePart/Options/Warnings.hs | 15 |
2 files changed, 16 insertions, 1 deletions
diff --git a/utils/mkUserGuidePart/Options/CompilerDebugging.hs b/utils/mkUserGuidePart/Options/CompilerDebugging.hs index 3f1d89999d..ce84a2a48b 100644 --- a/utils/mkUserGuidePart/Options/CompilerDebugging.hs +++ b/utils/mkUserGuidePart/Options/CompilerDebugging.hs @@ -120,7 +120,7 @@ compilerDebuggingOptions = , flagDescription = "Dump strictness analyser output" , flagType = DynamicFlag } - , flag { flagName = "-ddump-strsigs" + , flag { flagName = "-ddump-str-signatures" , flagDescription = "Dump strictness signatures" , flagType = DynamicFlag } diff --git a/utils/mkUserGuidePart/Options/Warnings.hs b/utils/mkUserGuidePart/Options/Warnings.hs index 37597f8e0f..a72395e194 100644 --- a/utils/mkUserGuidePart/Options/Warnings.hs +++ b/utils/mkUserGuidePart/Options/Warnings.hs @@ -141,17 +141,32 @@ warningsOptions = } , flag { flagName = "-Wmissing-exported-sigs" , flagDescription = + "*(deprecated)* "++ "warn about top-level functions without signatures, only if they "++ "are exported. takes precedence over -Wmissing-signatures" , flagType = DynamicFlag , flagReverse = "-Wno-missing-exported-sigs" } + , flag { flagName = "-Wmissing-exported-signatures" + , flagDescription = + "warn about top-level functions without signatures, only if they "++ + "are exported. takes precedence over -Wmissing-signatures" + , flagType = DynamicFlag + , flagReverse = "-Wno-missing-exported-signatures" + } , flag { flagName = "-Wmissing-local-sigs" , flagDescription = + "*(deprecated)* "++ "warn about polymorphic local bindings without signatures" , flagType = DynamicFlag , flagReverse = "-Wno-missing-local-sigs" } + , flag { flagName = "-Wmissing-local-signatures" + , flagDescription = + "warn about polymorphic local bindings without signatures" + , flagType = DynamicFlag + , flagReverse = "-Wno-missing-local-signatures" + } , flag { flagName = "-Wmissing-monadfail-instances" , flagDescription = "warn when a failable pattern is used in a do-block that does " ++ |