diff options
author | Sylvain Henry <sylvain@haskus.fr> | 2020-08-19 20:16:21 +0200 |
---|---|---|
committer | Marge Bot <ben+marge-bot@smart-cactus.org> | 2020-10-01 18:36:11 -0400 |
commit | a5aaceecaa04ce7ea5bade6eb96c0d129109c15a (patch) | |
tree | 80035738c384ef5e4bf8a4f943bbac5808c8c921 /utils | |
parent | dca1cb22cab4fa7f5937e9ffdc0ee32313dbd01c (diff) | |
download | haskell-a5aaceecaa04ce7ea5bade6eb96c0d129109c15a.tar.gz |
Use ADTs for parser errors/warnings
Haskell and Cmm parsers/lexers now report errors and warnings using ADTs
defined in GHC.Parser.Errors. They can be printed using functions in
GHC.Parser.Errors.Ppr.
Some of the errors provide hints with a separate ADT (e.g. to suggest to
turn on some extension). For now, however, hints are not consistent
across all messages. For example some errors contain the hints in the
main message. I didn't want to change any message with this patch. I
expect these changes to be discussed and implemented later.
Surprisingly, this patch enhances performance. On CI
(x86_64/deb9/hadrian, ghc/alloc):
parsing001 -11.5%
T13719 -2.7%
MultiLayerModules -3.5%
Naperian -3.1%
Bump haddock submodule
Metric Decrease:
MultiLayerModules
Naperian
T13719
parsing001
Diffstat (limited to 'utils')
m--------- | utils/haddock | 0 |
1 files changed, 0 insertions, 0 deletions
diff --git a/utils/haddock b/utils/haddock -Subproject a18c3af7f983f3b6d3cd84093c9079031da5846 +Subproject 7b5972402afad755cd45aaad1a96aac509e9d5d |