| Commit message (Collapse) | Author | Age | Files | Lines |
| |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
We now require python3 for the testsuite so rather than require two
versions of python it makes sense to use python3 for the linters as
well.
Reviewers: austin, bgamari
Reviewed By: bgamari
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D2888
|
|
|
|
|
|
|
|
|
|
| |
Test Plan: Try linting a cabal file with trailing whitespace
Reviewers: austin
Subscribers: thomie, alanz
Differential Revision: https://phabricator.haskell.org/D2799
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Add a linter to encourage the use of `$(TEST_HC_OPTS_INTERACTIVE)`
instead of `$(TEST_HC_OPTS) --interactive -ignore-dot-ghci -v0`. It's
too easy to forget one of those flags when adding a new test.
Update submodule hpc.
Reviewed by: austin
Differential Revision: https://phabricator.haskell.org/D2265
GHC Trac Issues: #11468
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This is to be merged once a fix for the Harbormaster build script has
been applied.
This reverts commit a14296c2660521db8ba965065687e45cee4e3401. These were
previously disabled due to Harbormaster validation failures.
Also, apply CPP check to .c and .h files in addition to Haskell sources.
Test Plan: Let Harbormaster validate
Reviewers: austin
Reviewed By: austin
Subscribers: hvr, thomie
Differential Revision: https://phabricator.haskell.org/D1580
|
|
|
|
|
|
|
|
|
|
|
| |
This temporarily disables the external json linters
introduced via
020375d1e723339a95b86d0d3b8a8214b1cc144a and
901cab10609dc9795e57163834512373530fc4a5.
The new linters break the differential validation in Harbormaster
because the submodules are not cloned early enough (i.e. before `arc` is
called by the script).
|
|
|
|
|
|
| |
In particular Clang rejects uses of CPP macros where the argument list
is separated by a space from the macro name. Warn when we see ASSERT
used in this way.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
This should catch mistakes like
a703fbce20969e6f02e74fee76c0a9e22b513426.
Adds an arcanist-external-json-linter submodule, which should eventually
be mirrored on haskell.org resources.
Test Plan: Validate
Reviewers: thomie, hvr, austin
Reviewed By: austin
Differential Revision: https://phabricator.haskell.org/D1515
|
|
|
|
|
|
|
|
|
|
|
|
| |
Test Plan: the linter works now
Reviewers: ezyang, austin, bgamari
Reviewed By: bgamari
Subscribers: thomie
Differential Revision: https://phabricator.haskell.org/D1359
|
|
|
|
| |
The section heading syntax trips up this linter. Fixes #10979.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Depends on D485
Summary: Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Test Plan: validate
Reviewers: simonpj, austin
Subscribers: thomie, carter
Differential Revision: https://phabricator.haskell.org/D487
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary: Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Test Plan: none
Reviewers: austin
Subscribers: simonmar, ezyang, carter, thomie
Differential Revision: https://phabricator.haskell.org/D303
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| |
Summary:
- Removed the default text rule that was applied to all files; it
produced way too many spurious warnings. For now, text lint is applied
to C, Haskell and Shell. Add more if you care.
- Makefiles and shell scripts had their max line length bumped a healthy
amount.
A pile of files still fail to lint, so these might even still be too
aggressive.
Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu>
Test Plan: none
Reviewers: hvr, austin
Subscribers: simonmar, relrod, ezyang, carter
Differential Revision: https://phabricator.haskell.org/D131
|
|
|
|
| |
Signed-off-by: Austin Seipp <austin@well-typed.com>
|
|
|
|
|
|
|
| |
As pointed out by Edward, it's probably unreasonable to have the xml
docs adhere to 80 columns, so we'll separate out the linters for now.
Signed-off-by: Austin Seipp <austin@well-typed.com>
|
|
|
|
| |
Signed-off-by: Austin Seipp <austin@well-typed.com>
|
|
Signed-off-by: Austin Seipp <austin@well-typed.com>
|