summaryrefslogtreecommitdiff
path: root/CODEOWNERS
Commit message (Collapse)AuthorAgeFilesLines
* Move `/includes` to `/rts/include`, sort per package betterwip/organize-headersJohn Ericson2021-08-031-4/+4
| | | | | | | | | | | | | | | | | | | | | | | | | | | In order to make the packages in this repo "reinstallable", we need to associate source code with a specific packages. Having a top level `/includes` dir that mixes concerns (which packages' includes?) gets in the way of this. To start, I have moved everything to `rts/`, which is mostly correct. There are a few things however that really don't belong in the rts (like the generated constants haskell type, `CodeGen.Platform.h`). Those needed to be manually adjusted. Things of note: - No symlinking for sake of windows, so we hard-link at configure time. - `CodeGen.Platform.h` no longer as `.hs` extension (in addition to being moved to `compiler/`) so as not to confuse anyone, since it is next to Haskell files. - Blanket `-Iincludes` is gone in both build systems, include paths now more strictly respect per-package dependencies. - `deriveConstants` has been taught to not require a `--target-os` flag when generating the platform-agnostic Haskell type. Make takes advantage of this, but Hadrian has yet to.
* CODEOWNERS: Add @DanielG as maintainer for RTS heap profiling codeDaniel Gröber2021-02-281-0/+13
|
* CODEOWNERS: Use sections to allow multiple matching entriesDaniel Gröber2021-02-281-6/+6
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The CODEOWNERS documentation has this to say on the current matching behaviour: > The path definition order is significant: the last pattern matching a > given path is used to find the code owners. Take this as an example: /rts/ bgamari [...] /rts/win32/ Phyx (I'm omitting the '@' so as to not notification spam everyone) This means a change in a file under win23 would only have Phyx but not bgamari as approver. I don't think that's the behaviour we want. Using "sections" we can get additive behaviour instead, from the docs: > Additionally, the usual guidance that only the last pattern matching the > file is applied is expanded such that the last pattern matching for each > section is applied. [RTS] /rts/ bgamari [...] [WinIO] /rts/win32/ Phyx So now since those entries are in different sections both would be added to the approvers list. The sections feature was introduced in Gitlab 13.2, see "Version history" on [1] we're currently running 18.8 on gitlab.haskell.org, see [2]. [1]: https://docs.gitlab.com/13.8/ee/user/project/code_owners.html#code-owners-sections [2]: https://gitlab.haskell.org/help
* winio: update codeownersTamar Christina2020-07-261-0/+15
|
* Modules: type-checker (#13009)Sylvain Henry2020-04-071-20/+20
| | | | Update Haddock submodule
* Simon and I like to work in hsSyn, too.Richard Eisenberg2019-07-231-0/+1
|
* CODEOWNERS: Use correct username for Richard EisenbergBen Gamari2019-05-301-6/+6
| | | | | | | In !980 Richard noted that he could not approve the MR. This mis-spelling was the reason. [skip ci]
* CODEOWNERS: Add simonmar as owner of rts/linkerBen Gamari2019-04-141-1/+1
| | | | | | I suspect this is why @simonmar wasn't notified of !706. [skip ci]
* Add myself to libraries/ghciSimon Marlow2019-04-021-0/+1
|
* Add int-index as parser/* codeownerVladislav Zavialov2019-02-061-0/+1
|
* Fix syntax in CODEOWNERS fileMatthew Pickering2019-01-311-28/+28
| | | | [skip ci]
* Update CODEOWNERS files with utilsTamar Christina2019-01-271-0/+2
|
* Add @simonmar to various things in CODEOWNERSSimon Marlow2019-01-271-3/+4
|
* Update CODEOWNERSMoritz Angermann2019-01-271-2/+13
|
* Add myself to a few more placesÖmer Sinan Ağacan2019-01-271-0/+2
|
* Add @sgraf to CODEOWNERSSebastian Graf2019-01-261-1/+3
| | | [skip ci]
* Add Simon and Richard as more CODEOWNERSRichard Eisenberg2019-01-241-0/+3
| | | | [skip ci]
* Add myself to CODEOWNERS for a few filesJoachim Breitner2019-01-231-0/+5
|
* Add CODEOWNERSBen Gamari2019-01-211-0/+22
GitLab uses this file to suggest reviewers based upon the files that a Merge Request touches. [skip-ci]
View Lorry Controller Status