summaryrefslogtreecommitdiff
path: root/rts/RtsUtils.c
Commit message (Collapse)AuthorAgeFilesLines
* Use segments for section layoutArtem Pyanykh2019-03-201-3/+3
|
* Update Trac ticket URLs to point to GitLabRyan Scott2019-03-151-1/+1
| | | | | This moves all URL references to Trac tickets to their corresponding GitLab counterparts.
* Show -with-rtsopts options in runtime's --info (#15261)roland2018-08-211-2/+4
| | | | | | | | | | | | | | | | | | Add an additional line to the output of +RTS --info. It shows the value of the flag -with-rtsopts provided at compile/link time. Test Plan: make test TESTS="T15261a T15261b" Reviewers: hvr, erikd, dfeuer, thomie, austin, bgamari, simonmar, osa1, monoidal Reviewed By: osa1, monoidal Subscribers: osa1, rwbarton, carter GHC Trac Issues: #15261 Differential Revision: https://phabricator.haskell.org/D5053
* Prefer #if defined to #ifdefBen Gamari2017-04-281-8/+8
| | | | Our new CPP linter enforces this.
* Enable new warning for fragile/incorrect CPP #if usageErik de Castro Lopo2017-04-281-2/+2
| | | | | | | | | | | | | | | | The C code in the RTS now gets built with `-Wundef` and the Haskell code (stages 1 and 2 only) with `-Wcpp-undef`. We now get warnings whereever `#if` is used on undefined identifiers. Test Plan: Validate on Linux and Windows Reviewers: austin, angerman, simonmar, bgamari, Phyx Reviewed By: bgamari Subscribers: thomie, snowleopard Differential Revision: https://phabricator.haskell.org/D3278
* rts/RtsUtils.c: drop stale commentsSergei Trofimovich2017-04-161-3/+3
| | | | Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>
* Revert "Enable new warning for fragile/incorrect CPP #if usage"Ben Gamari2017-04-051-2/+2
| | | | | | | | This is causing too much platform dependent breakage at the moment. We will need a more rigorous testing strategy before this can be merged again. This reverts commit 7e340c2bbf4a56959bd1e95cdd1cfdb2b7e537c2.
* Enable new warning for fragile/incorrect CPP #if usageErik de Castro Lopo2017-04-051-2/+2
| | | | | | | | | | | | | | | | The C code in the RTS now gets built with `-Wundef` and the Haskell code (stages 1 and 2 only) with `-Wcpp-undef`. We now get warnings whereever `#if` is used on undefined identifiers. Test Plan: Validate on Linux and Windows Reviewers: austin, angerman, simonmar, bgamari, Phyx Reviewed By: bgamari Subscribers: thomie, snowleopard Differential Revision: https://phabricator.haskell.org/D3278
* Report heap overflow in the same way as stack overflowSimon Marlow2017-04-021-14/+6
| | | | | | | | | | | | | | | | | | | | | | | Now that we throw an exception for heap overflow, we should only print the heap overflow message in the main thread when the HeapOverflow exception is caught, rather than as a side effect in the GC. Stack overflows were already done this way, I just made heap overflow consistent with stack overflow, and did some related cleanup. Fixes broken T2592(profasm) which was reporting the heap overflow message twice (you would only notice when building with profiling libs enabled). Test Plan: validate Reviewers: bgamari, niteria, austin, DemiMarie, hvr, erikd Reviewed By: bgamari Subscribers: rwbarton, thomie Differential Revision: https://phabricator.haskell.org/D3394
* Use C99's boolBen Gamari2016-11-291-2/+2
| | | | | | | | | | | | Test Plan: Validate on lots of platforms Reviewers: erikd, simonmar, austin Reviewed By: erikd, simonmar Subscribers: michalt, thomie Differential Revision: https://phabricator.haskell.org/D2699
* When in sanity mode, un-zero malloc'd memory; fix uninitialized memory bugs.Edward Z. Yang2016-08-151-0/+1
| | | | | | | | | | | | | | | | malloc'd memory is not guaranteed to be zeroed. On Linux, however, it is often zeroed, leading to latent bugs. In fact, with this patch I fix two uninitialized memory bugs stemming from this. Signed-off-by: Edward Z. Yang <ezyang@cs.stanford.edu> Test Plan: validate Reviewers: simonmar, austin, Phyx, bgamari, erikd Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2455
* RtsUtils: Use `size_t` instead of `int` where appropriateErik de Castro Lopo2016-05-121-13/+9
| | | | | | | | | | | | | | | | | | | Functions like `stgMallocBytes` take a size parameter which was of type `int`, but is commonly used as `stgMallocBytes (sizeof (...))`. This is problematic because the `sizeof` operator returns `size_t` so that on 64 bit systems, in this common use case the `size_t` parameter would be truncated to 32 bits when passed to `stgMallocBytes` where it was cast back to `size_t`. Test Plan: Validate on Linux, OS X and Windows Reviewers: austin, hvr, bgamari, simonmar, hsyl20 Reviewed By: hvr, bgamari, simonmar, hsyl20 Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2201
* rts: Don't use strndupBen Gamari2016-04-181-0/+12
| | | | | | | | Reviewers: austin Subscribers: thomie Differential Revision: https://phabricator.haskell.org/D2125
* stgMallocBytes: Tolerate malloc(0) returning a NULL ptrHerbert Valerio Riedel2016-03-211-0/+13
| | | | | | | | | | | | | | This is valid behaviour for `malloc()` according to ISO C99 and POSIX, and there's at least one operating system (AIX) which actually does return NULL for 0-sized allocations. The `createAdjustor()` routine is currently the only known use-site of `stgMallocBytes` which may call `stgMallocBytes()` requesting a 0-size allocation. Reviewed By: bgamari, austin Differential Revision: https://phabricator.haskell.org/D2022
* Fix two occurences of `x86_HOST_ARCH`Herbert Valerio Riedel2015-12-191-1/+1
| | | | | | | | | | | | | | | The proper name for the define is `i386_HOST_ARCH` One was introduced back in 2011 via 035b8ebb5405efbcbfd3474821a877add1feca1e / #4914 and the other one more recently via 4905b83a2d448c65ccced385343d4e8124548a3b We may want to add some validation to catch such typos early on... Reviewed By: erikd Differential Revision: https://phabricator.haskell.org/D1664
* Replace hooks by callbacks in RtsConfig (#8785)Simon Marlow2015-04-071-6/+7
| | | | | | | | | | | | Summary: Hooks rely on static linking semantics, and are broken by -Bsymbolic which we need when using dynamic linking. Test Plan: Built it Reviewers: austin, hvr, tibbe Differential Revision: https://phabricator.haskell.org/D8
* Revert "rts: add Emacs 'Local Variables' to every .c file"Simon Marlow2014-09-291-8/+0
| | | | This reverts commit 39b5c1cbd8950755de400933cecca7b8deb4ffcd.
* rts: detabify/dewhitespace RtsUtils.cAustin Seipp2014-08-201-7/+7
| | | | Signed-off-by: Austin Seipp <austin@well-typed.com>
* rts: add Emacs 'Local Variables' to every .c fileAustin Seipp2014-07-281-0/+8
| | | | | | | | This will hopefully help ensure some basic consistency in the forward by overriding buffer variables. In particular, it sets the wrap length, the offset to 4, and turns off tabs. Signed-off-by: Austin Seipp <austin@well-typed.com>
* rts: Print correct stack size on stack overflowBen Gamari2013-10-251-3/+3
| | | | | This requires that stackOverflow() in RtsUtils.c be passed a reference to the current TSO. This requires a small change in libraries/base.
* Use dynamic linking only if the GHC package is compiled with -dynamic (#8376)Simon Marlow2013-10-111-0/+11
|
* Revert "Default to infinite stack size (#8189)"Austin Seipp2013-09-081-3/+3
| | | | This reverts commit d85044f6b201eae0a9e453b89c0433608e0778f0.
* Default to infinite stack size (#8189)Austin Seipp2013-09-081-3/+3
| | | | | | | | | | | | | When servicing a stack overflows, only throw an exception to the given thread if the user explicitly set a max stack size, using +RTS -K. Otherwise just service it normally and grow the stack. In case we actually run out of *heap* (stack chuncks are allocated on the heap), then we need to bail by calling the stackOverflow() hook and exit immediately. Authored-by: Ben Gamari <bgamari.foss@gmail.com> Signed-off-by: Austin Seipp <aseipp@pobox.com>
* Move the genSym stuff from rts into compilerIan Lynagh2013-05-171-20/+0
| | | | | It's no longer used by Data.Unique, so there's no need to have it in rts any more.
* Use pthread_kill on OS X tooIan Lynagh2013-01-171-1/+1
| | | | Fixes signals004(threaded1,threaded2) on OS X 32.
* Deprecate lnat, and use StgWord insteadSimon Marlow2012-09-071-1/+1
| | | | | | | | | | | | lnat was originally "long unsigned int" but we were using it when we wanted a 64-bit type on a 64-bit machine. This broke on Windows x64, where long == int == 32 bits. Using types of unspecified size is bad, but what we really wanted was a type with N bits on an N-bit machine. StgWord is exactly that. lnat was mentioned in some APIs that clients might be using (e.g. StackOverflowHook()), so we leave it defined but with a comment to say that it's deprecated.
* avoid 32-bit integer overflow (#5831)Simon Marlow2012-02-071-1/+1
|
* Fixes for NetBSDIan Lynagh2011-11-251-1/+1
| | | | | Based on a patch from Arnaud Degroote <degroote@NetBSD.org> in trac #5480.
* Add a debug check for a non-empty FPU stack on x86 (see #4914)Simon Marlow2011-03-301-0/+15
|
* Remove the debugging memory allocator - valgrind does a better jobSimon Marlow2010-08-241-146/+0
| | | | | | | | | | | | | | | | | | | | | | | | | | | | I got fed up with the constant bogus output from the debugging memory allocator in RtsUtils.c. One problem is that we allocate memory in constructors that then isn't tracked, because the debugging allocator hasn't been initialised yet. The bigger problem is that for a given piece of leaking memory it's impossible to find out where it was allocated; however Valgrind gives output like this: ==6967== 8 bytes in 1 blocks are still reachable in loss record 1 of 7 ==6967== at 0x4C284A8: malloc (vg_replace_malloc.c:236) ==6967== by 0x4C28522: realloc (vg_replace_malloc.c:525) ==6967== by 0x6745E9: stgReallocBytes (RtsUtils.c:213) ==6967== by 0x68D812: setHeapAlloced (MBlock.c:91) ==6967== by 0x68D8E2: markHeapAlloced (MBlock.c:116) ==6967== by 0x68DB56: getMBlocks (MBlock.c:240) ==6967== by 0x684F55: alloc_mega_group (BlockAlloc.c:305) ==6967== by 0x6850C8: allocGroup (BlockAlloc.c:358) ==6967== by 0x69484F: allocNursery (Storage.c:390) ==6967== by 0x694ABD: allocNurseries (Storage.c:436) ==6967== by 0x6944F2: initStorage (Storage.c:217) ==6967== by 0x673E3C: hs_init (RtsStartup.c:160) which tells us exactly what the leaking bit of memory is. So I don't think we need our own debugging allocator.
* stgReallocBytes(DEBUG): don't fail when the ptr passed in is NULLSimon Marlow2010-08-171-1/+1
|
* Reorder RTS --info outputIan Lynagh2010-07-171-4/+4
|
* Use StgWord64 instead of ullongIan Lynagh2010-04-211-18/+67
| | | | | | This patch also fixes ullong_format_string (renamed to showStgWord64) so that it works with values outside the 32bit range (trac #3979), and simplifies the without-commas case.
* fix a non-portable printf formatSimon Marlow2010-03-301-2/+2
|
* Support for DragonFly BSDSimon Marlow2009-11-111-1/+1
| | | | | | Patches from Goetz Isenmann <info@goetz-isenmann.de>, slightly updated for HEAD (the method for configuring platforms in configure.ac has changed).
* RTS tidyup sweep, first phaseSimon Marlow2009-08-021-56/+1
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The first phase of this tidyup is focussed on the header files, and in particular making sure we are exposinng publicly exactly what we need to, and no more. - Rts.h now includes everything that the RTS exposes publicly, rather than a random subset of it. - Most of the public header files have moved into subdirectories, and many of them have been renamed. But clients should not need to include any of the other headers directly, just #include the main public headers: Rts.h, HsFFI.h, RtsAPI.h. - All the headers needed for via-C compilation have moved into the stg subdirectory, which is self-contained. Most of the headers for the rest of the RTS APIs have moved into the rts subdirectory. - I left MachDeps.h where it is, because it is so widely used in Haskell code. - I left a deprecated stub for RtsFlags.h in place. The flag structures are now exposed by Rts.h. - Various internal APIs are no longer exposed by public header files. - Various bits of dead code and declarations have been removed - More gcc warnings are turned on, and the RTS code is more warning-clean. - More source files #include "PosixSource.h", and hence only use standard POSIX (1003.1c-1995) interfaces. There is a lot more tidying up still to do, this is just the first pass. I also intend to standardise the names for external RTS APIs (e.g use the rts_ prefix consistently), and declare the internal APIs as hidden for shared libraries.
* Fix a warning on WindowsIan Lynagh2009-07-241-1/+1
|
* add number of bytes to +RTS -DS leak reportsSimon Marlow2009-07-241-2/+2
|
* Fix #2197 (properly this time)Simon Marlow2009-07-011-0/+10
| | | | | | | $ ./inplace/bin/ghc-stage2 --interactive GHCi, version 6.11.20090701: http://www.haskell.org/ghc/ :? for help ghc-stage2: GHCi cannot be used when compiled with -prof [1] 32473 exit 1 ./inplace/bin/ghc-stage2 --interactive
* Remove old GUM/GranSim codeSimon Marlow2009-06-021-37/+0
|
* In +RTS --info output, use YES rather than YesIan Lynagh2009-02-271-1/+1
|
* Add "Word size" to the +RTS --info outputIan Lynagh2009-01-091-0/+6
|
* Add some more fields to +RTS --infoIan Lynagh2009-01-081-0/+9
|
* Fix #2592: do an orderly shutdown when the heap is exhaustedSimon Marlow2008-12-091-8/+8
| | | | | | Really we should be raising an exception in this case, but that's tricky (see comments). At least now we shut down the runtime correctly rather than just exiting.
* Declare ctime_r on Mac OSRoman Leshchinskiy2007-09-061-0/+7
| | | | | | On Mac OS, ctime_r is not declared in time.h if _POSIX_C_SOURCE is defined. We work around this by providing a declaration ourselves.
* Document +RTS --info, and make it a Read'able Haskell valueIan Lynagh2007-08-161-0/+20
|
* Basic heap profile support without -profSimon Marlow2007-04-271-2/+0
| | | | | | | | | | | | | | Now that constructor info tables contain the name of the constructor, we can generate useful heap profiles without requiring the whole program and libraries to be compiled with -prof. So now, "+RTS -hT" generates a heap profile for any program, dividing the profile by constructor. It wouldn't be hard to add support for grouping constructors by module, or to restrict the profile to certain constructors/modules/packages. This means that for the first time we can get heap profiles for GHCi, which was previously impossible because the byte-code interpreter and linker don't work with -prof.
* Fix C/Haskell type mismatchesIan Lynagh2007-04-031-3/+3
|
* Don't overwrite old memory with 0xaa when doing a reallocIan Lynagh2006-12-181-4/+6
|
* Fix allocation debugger to handle allocations in con/destructorsIan Lynagh2006-12-131-29/+64
| | | | | | conc021 is an example of a program that broke. It doesn't handle them particularly well still, but it doesn't crash at least.
View Lorry Controller Status