From 643d42fcf68f9b96bc8829d20bcd8f5fef84a78c Mon Sep 17 00:00:00 2001 From: Alp Mestanogullari Date: Tue, 12 Nov 2019 18:59:07 +0100 Subject: testsuite: don't collect compiler stats in collect_runtime_residency We instead want to collect the runtime stats (with collect_stats, instead of collect_compiler_stats). This should fix a number of perf tests failures we have been seeing, where we suddenly started measuring metrics we didn't intend to measure, which tend to fall outside of the acceptance window. Metric Decrease: lazy-bs-alloc T3586 Metric Increase: space_leak_001 T4801 T5835 T12791 --- testsuite/driver/testlib.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'testsuite/driver/testlib.py') diff --git a/testsuite/driver/testlib.py b/testsuite/driver/testlib.py index 35bb4ad32e..79d504a845 100644 --- a/testsuite/driver/testlib.py +++ b/testsuite/driver/testlib.py @@ -583,7 +583,7 @@ RESIDENCY_OPTS = '+RTS -A256k -i0 -h -RTS' # See Note [Measuring residency]. def collect_runtime_residency(tolerance_pct: float): return [ - collect_compiler_stats(['peak_megabytes_allocated', 'max_bytes_used'], tolerance_pct), + collect_stats(['peak_megabytes_allocated', 'max_bytes_used'], tolerance_pct), extra_run_opts(RESIDENCY_OPTS), # The nonmoving collector does not support -G1 omit_ways([WayName(name) for name in ['nonmoving', 'nonmoving_thr', 'nonmoving_thr_ghc']]) -- cgit v1.2.1