{-# LANGUAGE FlexibleContexts #-} {-# LANGUAGE TupleSections #-} {-# OPTIONS_GHC -Wno-incomplete-uni-patterns #-} {- (c) The GRASP/AQUA Project, Glasgow University, 1992-2012 Note [Unarisation] ~~~~~~~~~~~~~~~~~~ The idea of this pass is to translate away *all* unboxed-tuple and unboxed-sum binders. So for example: f (x :: (# Int, Bool #)) = f x + f (# 1, True #) ==> f (x1 :: Int) (x2 :: Bool) = f x1 x2 + f 1 True It is important that we do this at the STG level and NOT at the Core level because it would be very hard to make this pass Core-type-preserving. In this example the type of 'f' changes, for example. STG fed to the code generators *must* be unarised because the code generators do not support unboxed tuple and unboxed sum binders natively. In more detail: (see next note for unboxed sums) Suppose that a variable x : (# t1, t2 #). * At the binding site for x, make up fresh vars x1:t1, x2:t2 * Extend the UnariseEnv x :-> MultiVal [x1,x2] * Replace the binding with a curried binding for x1,x2 Lambda: \x.e ==> \x1 x2. e Case alt: MkT a b x c d -> e ==> MkT a b x1 x2 c d -> e * Replace argument occurrences with a sequence of args via a lookup in UnariseEnv f a b x c d ==> f a b x1 x2 c d * Replace tail-call occurrences with an unboxed tuple via a lookup in UnariseEnv x ==> (# x1, x2 #) So, for example f x = x ==> f x1 x2 = (# x1, x2 #) * We /always/ eliminate a case expression when - It scrutinises an unboxed tuple or unboxed sum - The scrutinee is a variable (or when it is an explicit tuple, but the simplifier eliminates those) The case alternative (there can be only one) can be one of these two things: - An unboxed tuple pattern. e.g. case v of x { (# x1, x2, x3 #) -> ... } Scrutinee has to be in form `(# t1, t2, t3 #)` so we just extend the environment with x :-> MultiVal [t1,t2,t3] x1 :-> UnaryVal t1, x2 :-> UnaryVal t2, x3 :-> UnaryVal t3 - A DEFAULT alternative. Just the same, without the bindings for x1,x2,x3 By the end of this pass, we only have unboxed tuples in return positions. Unboxed sums are completely eliminated, see next note. Note [Translating unboxed sums to unboxed tuples] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Unarise also eliminates unboxed sum binders, and translates unboxed sums in return positions to unboxed tuples. We want to overlap fields of a sum when translating it to a tuple to have efficient memory layout. When translating a sum pattern to a tuple pattern, we need to translate it so that binders of sum alternatives will be mapped to right arguments after the term translation. So translation of sum DataCon applications to tuple DataCon applications and translation of sum patterns to tuple patterns need to be in sync. These translations work like this. Suppose we have (# x1 | | ... #) :: (# t1 | t2 | ... #) remember that t1, t2 ... can be sums and tuples too. So we first generate layouts of those. Then we "merge" layouts of each alternative, which gives us a sum layout with best overlapping possible. Layout of a flat type 'ty1' is just [ty1]. Layout of a tuple is just concatenation of layouts of its fields. For layout of a sum type, - We first get layouts of all alternatives. - We sort these layouts based on their "slot types". - We merge all the alternatives. For example, say we have (# (# Int#, Char #) | (# Int#, Int# #) | Int# #) - Layouts of alternatives: [ [Word, LiftedPtr], [Word, Word], [Word] ] - Sorted: [ [LiftedPtr, Word], [Word, Word], [Word] ] - Merge all alternatives together: [ LiftedPtr, Word, Word ] We add a slot for the tag to the first position. So our tuple type is (# Tag#, Any, Word#, Word# #) (we use Any for pointer slots) Now, any term of this sum type needs to generate a tuple of this type instead. The translation works by simply putting arguments to first slots that they fit in. Suppose we had (# (# 42#, 'c' #) | | #) 42# fits in Word#, 'c' fits in Any, so we generate this application: (# 1#, 'c', 42#, rubbish #) Another example using the same type: (# | (# 2#, 3# #) | #). 2# fits in Word#, 3# fits in Word #, so we get: (# 2#, rubbish, 2#, 3# #). Note [Don't merge lifted and unlifted slots] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ When merging slots, one might be tempted to collapse lifted and unlifted pointers. However, as seen in #19645, this is wrong. Imagine that you have the program: test :: (# Char | ByteArray# #) -> ByteArray# test (# c | #) = doSomething c test (# | ba #) = ba Collapsing the Char and ByteArray# slots would produce STG like: test :: forall {t}. (# t | GHC.Prim.ByteArray# #) -> GHC.Prim.ByteArray# = {} \r [ (tag :: Int#) (slot0 :: (Any :: Type)) ] case tag of tag' 1# -> doSomething slot0 2# -> slot0; Note how `slot0` has a lifted type, despite being bound to an unlifted ByteArray# in the 2# alternative. This liftedness would cause the code generator to attempt to enter it upon returning. As unlifted objects do not have entry code, this causes a runtime crash. For this reason, Unarise treats unlifted and lifted things as distinct slot types, despite both being GC pointers. This approach is a slight pessimisation (since we need to pass more arguments) but appears to be the simplest way to avoid #19645. Other alternatives considered include: a. Giving unlifted objects "trivial" entry code. However, we ultimately concluded that the value of the "unlifted things are never entered" invariant outweighed the simplicity of this approach. b. Annotating occurrences with calling convention information instead of relying on the binder's type. This seemed like a very complicated way to fix what is ultimately a corner-case. Note [Types in StgConApp] ~~~~~~~~~~~~~~~~~~~~~~~~~ Suppose we have this unboxed sum term: (# 123 | #) What will be the unboxed tuple representation? We can't tell without knowing the type of this term. For example, these are all valid tuples for this: (# 1#, 123 #) -- when type is (# Int | String #) (# 1#, 123, rubbish #) -- when type is (# Int | Float# #) (# 1#, 123, rubbish, rubbish #) -- when type is (# Int | (# Int, Int, Int #) #) So we pass type arguments of the DataCon's TyCon in StgConApp to decide what layout to use. Note that unlifted values can't be let-bound, so we don't need types in StgRhsCon. Note [UnariseEnv can map to literals] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ To avoid redundant case expressions when unarising unboxed sums, UnariseEnv needs to map variables to literals too. Suppose we have this Core: f (# x | #) ==> (CorePrep) case (# x | #) of y { _ -> f y } ==> (MultiVal) case (# 1#, x #) of [x1, x2] { _ -> f x1 x2 } To eliminate this case expression we need to map x1 to 1# in UnariseEnv: x1 :-> UnaryVal 1#, x2 :-> UnaryVal x so that `f x1 x2` becomes `f 1# x`. Note [Unarisation and arity] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Because of unarisation, the arity that will be recorded in the generated info table for an Id may be larger than the idArity. Instead we record what we call the RepArity, which is the Arity taking into account any expanded arguments, and corresponds to the number of (possibly-void) *registers* arguments will arrive in. Note [Post-unarisation invariants] ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ STG programs after unarisation have these invariants: * No unboxed sums at all. * No unboxed tuple binders. Tuples only appear in return position. * DataCon applications (StgRhsCon and StgConApp) don't have void arguments. This means that it's safe to wrap `StgArg`s of DataCon applications with `GHC.StgToCmm.Env.NonVoid`, for example. * Similar to unboxed tuples, Note [Rubbish literals] of TupleRep may only appear in return position. * Alt binders (binders in patterns) are always non-void. * Binders always have zero (for void arguments) or one PrimRep. -} module GHC.Stg.Unarise (unarise) where import GHC.Prelude import GHC.Types.Basic import GHC.Core import GHC.Core.DataCon import GHC.Core.TyCon ( isVoidRep ) import GHC.Data.FastString (FastString, mkFastString) import GHC.Types.Id import GHC.Types.Literal import GHC.Core.Make (aBSENT_SUM_FIELD_ERROR_ID) import GHC.Types.Id.Make (voidPrimId, voidArgId) import GHC.Utils.Monad (mapAccumLM) import GHC.Utils.Outputable import GHC.Utils.Panic import GHC.Utils.Panic.Plain import GHC.Types.RepType import GHC.Stg.Syntax import GHC.Core.Type import GHC.Builtin.Types.Prim (intPrimTy) import GHC.Builtin.Types import GHC.Types.Unique.Supply import GHC.Utils.Misc import GHC.Types.Var.Env import Data.Bifunctor (second) import Data.Maybe (mapMaybe) import qualified Data.IntMap as IM -------------------------------------------------------------------------------- -- | A mapping from binders to the Ids they were expanded/renamed to. -- -- x :-> MultiVal [a,b,c] in rho -- -- iff x's typePrimRep is not a singleton, or equivalently -- x's type is an unboxed tuple, sum or void. -- -- x :-> UnaryVal x' -- -- iff x's RepType is UnaryRep or equivalently -- x's type is not unboxed tuple, sum or void. -- -- So -- x :-> MultiVal [a] in rho -- means x is represented by singleton tuple. -- -- x :-> MultiVal [] in rho -- means x is void. -- -- INVARIANT: OutStgArgs in the range only have NvUnaryTypes -- (i.e. no unboxed tuples, sums or voids) -- type UnariseEnv = VarEnv UnariseVal data UnariseVal = MultiVal [OutStgArg] -- MultiVal to tuple. Can be empty list (void). | UnaryVal OutStgArg -- See NOTE [Renaming during unarisation]. instance Outputable UnariseVal where ppr (MultiVal args) = text "MultiVal" <+> ppr args ppr (UnaryVal arg) = text "UnaryVal" <+> ppr arg -- | Extend the environment, checking the UnariseEnv invariant. extendRho :: UnariseEnv -> Id -> UnariseVal -> UnariseEnv extendRho rho x (MultiVal args) = assert (all (isNvUnaryType . stgArgType) args) extendVarEnv rho x (MultiVal args) extendRho rho x (UnaryVal val) = assert (isNvUnaryType (stgArgType val)) extendVarEnv rho x (UnaryVal val) -------------------------------------------------------------------------------- unarise :: UniqSupply -> [StgTopBinding] -> [StgTopBinding] unarise us binds = initUs_ us (mapM (unariseTopBinding emptyVarEnv) binds) unariseTopBinding :: UnariseEnv -> StgTopBinding -> UniqSM StgTopBinding unariseTopBinding rho (StgTopLifted bind) = StgTopLifted <$> unariseBinding rho bind unariseTopBinding _ bind@StgTopStringLit{} = return bind unariseBinding :: UnariseEnv -> StgBinding -> UniqSM StgBinding unariseBinding rho (StgNonRec x rhs) = StgNonRec x <$> unariseRhs rho rhs unariseBinding rho (StgRec xrhss) = StgRec <$> mapM (\(x, rhs) -> (x,) <$> unariseRhs rho rhs) xrhss unariseRhs :: UnariseEnv -> StgRhs -> UniqSM StgRhs unariseRhs rho (StgRhsClosure ext ccs update_flag args expr) = do (rho', args1) <- unariseFunArgBinders rho args expr' <- unariseExpr rho' expr return (StgRhsClosure ext ccs update_flag args1 expr') unariseRhs rho (StgRhsCon ccs con mu ts args) = assert (not (isUnboxedTupleDataCon con || isUnboxedSumDataCon con)) return (StgRhsCon ccs con mu ts (unariseConArgs rho args)) -------------------------------------------------------------------------------- unariseExpr :: UnariseEnv -> StgExpr -> UniqSM StgExpr unariseExpr rho e@(StgApp f []) = case lookupVarEnv rho f of Just (MultiVal args) -- Including empty tuples -> return (mkTuple args) Just (UnaryVal (StgVarArg f')) -> return (StgApp f' []) Just (UnaryVal (StgLitArg f')) -> return (StgLit f') Nothing -> return e unariseExpr rho e@(StgApp f args) = return (StgApp f' (unariseFunArgs rho args)) where f' = case lookupVarEnv rho f of Just (UnaryVal (StgVarArg f')) -> f' Nothing -> f err -> pprPanic "unariseExpr - app2" (pprStgExpr panicStgPprOpts e $$ ppr err) -- Can't happen because 'args' is non-empty, and -- a tuple or sum cannot be applied to anything unariseExpr _ (StgLit l) = return (StgLit l) unariseExpr rho (StgConApp dc n args ty_args) | Just args' <- unariseMulti_maybe rho dc args ty_args = return (mkTuple args') | otherwise , let args' = unariseConArgs rho args = return (StgConApp dc n args' (map stgArgType args')) unariseExpr rho (StgOpApp op args ty) = return (StgOpApp op (unariseFunArgs rho args) ty) unariseExpr rho (StgCase scrut bndr alt_ty alts) -- tuple/sum binders in the scrutinee can always be eliminated | StgApp v [] <- scrut , Just (MultiVal xs) <- lookupVarEnv rho v = elimCase rho xs bndr alt_ty alts -- Handle strict lets for tuples and sums: -- case (# a,b #) of r -> rhs -- and analogously for sums | StgConApp dc _n args ty_args <- scrut , Just args' <- unariseMulti_maybe rho dc args ty_args = elimCase rho args' bndr alt_ty alts -- See (3) of Note [Rubbish literals] in GHC.Types.Literal | StgLit lit <- scrut , Just args' <- unariseRubbish_maybe lit = elimCase rho args' bndr alt_ty alts -- general case | otherwise = do scrut' <- unariseExpr rho scrut alts' <- unariseAlts rho alt_ty bndr alts return (StgCase scrut' bndr alt_ty alts') -- bndr may have a unboxed sum/tuple type but it will be -- dead after unarise (checked in GHC.Stg.Lint) unariseExpr rho (StgLet ext bind e) = StgLet ext <$> unariseBinding rho bind <*> unariseExpr rho e unariseExpr rho (StgLetNoEscape ext bind e) = StgLetNoEscape ext <$> unariseBinding rho bind <*> unariseExpr rho e unariseExpr rho (StgTick tick e) = StgTick tick <$> unariseExpr rho e -- Doesn't return void args. unariseMulti_maybe :: UnariseEnv -> DataCon -> [InStgArg] -> [Type] -> Maybe [OutStgArg] unariseMulti_maybe rho dc args ty_args | isUnboxedTupleDataCon dc = Just (unariseConArgs rho args) | isUnboxedSumDataCon dc , let args1 = assert (isSingleton args) (unariseConArgs rho args) = Just (mkUbxSum dc ty_args args1) | otherwise = Nothing -- Doesn't return void args. unariseRubbish_maybe :: Literal -> Maybe [OutStgArg] unariseRubbish_maybe (LitRubbish rep) | [prep] <- preps , not (isVoidRep prep) = Nothing -- Single, non-void PrimRep. Nothing to do! | otherwise -- Multiple reps, possibly with VoidRep. Eliminate via elimCase = Just [ StgLitArg (LitRubbish (primRepToType prep)) | prep <- preps, not (isVoidRep prep) ] where preps = runtimeRepPrimRep (text "unariseRubbish_maybe") rep unariseRubbish_maybe _ = Nothing -------------------------------------------------------------------------------- elimCase :: UnariseEnv -> [OutStgArg] -- non-void args -> InId -> AltType -> [InStgAlt] -> UniqSM OutStgExpr elimCase rho args bndr (MultiValAlt _) [(_, bndrs, rhs)] = do let rho1 = extendRho rho bndr (MultiVal args) rho2 | isUnboxedTupleBndr bndr = mapTupleIdBinders bndrs args rho1 | otherwise = assert (isUnboxedSumBndr bndr) $ if null bndrs then rho1 else mapSumIdBinders bndrs args rho1 unariseExpr rho2 rhs elimCase rho args bndr (MultiValAlt _) alts | isUnboxedSumBndr bndr = do let (tag_arg : real_args) = args tag_bndr <- mkId (mkFastString "tag") tagTy -- this won't be used but we need a binder anyway let rho1 = extendRho rho bndr (MultiVal args) scrut' = case tag_arg of StgVarArg v -> StgApp v [] StgLitArg l -> StgLit l alts' <- unariseSumAlts rho1 real_args alts return (StgCase scrut' tag_bndr tagAltTy alts') elimCase _ args bndr alt_ty alts = pprPanic "elimCase - unhandled case" (ppr args <+> ppr bndr <+> ppr alt_ty $$ pprPanicAlts alts) -------------------------------------------------------------------------------- unariseAlts :: UnariseEnv -> AltType -> InId -> [StgAlt] -> UniqSM [StgAlt] unariseAlts rho (MultiValAlt n) bndr [(DEFAULT, [], e)] | isUnboxedTupleBndr bndr = do (rho', ys) <- unariseConArgBinder rho bndr e' <- unariseExpr rho' e return [(DataAlt (tupleDataCon Unboxed n), ys, e')] unariseAlts rho (MultiValAlt n) bndr [(DataAlt _, ys, e)] | isUnboxedTupleBndr bndr = do (rho', ys1) <- unariseConArgBinders rho ys massert (ys1 `lengthIs` n) let rho'' = extendRho rho' bndr (MultiVal (map StgVarArg ys1)) e' <- unariseExpr rho'' e return [(DataAlt (tupleDataCon Unboxed n), ys1, e')] unariseAlts _ (MultiValAlt _) bndr alts | isUnboxedTupleBndr bndr = pprPanic "unariseExpr: strange multi val alts" (pprPanicAlts alts) -- In this case we don't need to scrutinize the tag bit unariseAlts rho (MultiValAlt _) bndr [(DEFAULT, _, rhs)] | isUnboxedSumBndr bndr = do (rho_sum_bndrs, sum_bndrs) <- unariseConArgBinder rho bndr rhs' <- unariseExpr rho_sum_bndrs rhs return [(DataAlt (tupleDataCon Unboxed (length sum_bndrs)), sum_bndrs, rhs')] unariseAlts rho (MultiValAlt _) bndr alts | isUnboxedSumBndr bndr = do (rho_sum_bndrs, scrt_bndrs@(tag_bndr : real_bndrs)) <- unariseConArgBinder rho bndr alts' <- unariseSumAlts rho_sum_bndrs (map StgVarArg real_bndrs) alts let inner_case = StgCase (StgApp tag_bndr []) tag_bndr tagAltTy alts' return [ (DataAlt (tupleDataCon Unboxed (length scrt_bndrs)), scrt_bndrs, inner_case) ] unariseAlts rho _ _ alts = mapM (\alt -> unariseAlt rho alt) alts unariseAlt :: UnariseEnv -> StgAlt -> UniqSM StgAlt unariseAlt rho (con, xs, e) = do (rho', xs') <- unariseConArgBinders rho xs (con, xs',) <$> unariseExpr rho' e -------------------------------------------------------------------------------- -- | Make alternatives that match on the tag of a sum -- (i.e. generate LitAlts for the tag) unariseSumAlts :: UnariseEnv -> [StgArg] -- sum components _excluding_ the tag bit. -> [StgAlt] -- original alternative with sum LHS -> UniqSM [StgAlt] unariseSumAlts env args alts = do alts' <- mapM (unariseSumAlt env args) alts return (mkDefaultLitAlt alts') unariseSumAlt :: UnariseEnv -> [StgArg] -- sum components _excluding_ the tag bit. -> StgAlt -- original alternative with sum LHS -> UniqSM StgAlt unariseSumAlt rho _ (DEFAULT, _, e) = ( DEFAULT, [], ) <$> unariseExpr rho e unariseSumAlt rho args (DataAlt sumCon, bs, e) = do let rho' = mapSumIdBinders bs args rho e' <- unariseExpr rho' e return ( LitAlt (LitNumber LitNumInt (fromIntegral (dataConTag sumCon))), [], e' ) unariseSumAlt _ scrt alt = pprPanic "unariseSumAlt" (ppr scrt $$ pprPanicAlt alt) -------------------------------------------------------------------------------- mapTupleIdBinders :: [InId] -- Un-processed binders of a tuple alternative. -- Can have void binders. -> [OutStgArg] -- Arguments that form the tuple (after unarisation). -- Can't have void args. -> UnariseEnv -> UnariseEnv mapTupleIdBinders ids args0 rho0 = assert (not (any (isZeroBitTy . stgArgType) args0)) $ let ids_unarised :: [(Id, [PrimRep])] ids_unarised = map (\id -> (id, typePrimRep (idType id))) ids map_ids :: UnariseEnv -> [(Id, [PrimRep])] -> [StgArg] -> UnariseEnv map_ids rho [] _ = rho map_ids rho ((x, x_reps) : xs) args = let x_arity = length x_reps (x_args, args') = assert (args `lengthAtLeast` x_arity) splitAt x_arity args rho' | x_arity == 1 = assert (x_args `lengthIs` 1) extendRho rho x (UnaryVal (head x_args)) | otherwise = extendRho rho x (MultiVal x_args) in map_ids rho' xs args' in map_ids rho0 ids_unarised args0 mapSumIdBinders :: [InId] -- Binder of a sum alternative (remember that sum patterns -- only have one binder, so this list should be a singleton) -> [OutStgArg] -- Arguments that form the sum (NOT including the tag). -- Can't have void args. -> UnariseEnv -> UnariseEnv mapSumIdBinders [id] args rho0 = assert (not (any (isZeroBitTy . stgArgType) args)) $ let arg_slots = map primRepSlot $ concatMap (typePrimRep . stgArgType) args id_slots = map primRepSlot $ typePrimRep (idType id) layout1 = layoutUbxSum arg_slots id_slots in if isMultiValBndr id then extendRho rho0 id (MultiVal [ args !! i | i <- layout1 ]) else assert (layout1 `lengthIs` 1) extendRho rho0 id (UnaryVal (args !! head layout1)) mapSumIdBinders ids sum_args _ = pprPanic "mapSumIdBinders" (ppr ids $$ ppr sum_args) -- | Build a unboxed sum term from arguments of an alternative. -- -- Example, for (# x | #) :: (# (# #) | Int #) we call -- -- mkUbxSum (# _ | #) [ (# #), Int ] [ voidPrimId ] -- -- which returns -- -- [ 1#, rubbish ] -- mkUbxSum :: DataCon -- Sum data con -> [Type] -- Type arguments of the sum data con -> [OutStgArg] -- Actual arguments of the alternative. -> [OutStgArg] -- Final tuple arguments mkUbxSum dc ty_args args0 = let (_ : sum_slots) = ubxSumRepType (map typePrimRep ty_args) -- drop tag slot tag = dataConTag dc layout' = layoutUbxSum sum_slots (mapMaybe (typeSlotTy . stgArgType) args0) tag_arg = StgLitArg (LitNumber LitNumInt (fromIntegral tag)) arg_idxs = IM.fromList (zipEqual "mkUbxSum" layout' args0) mkTupArgs :: Int -> [SlotTy] -> IM.IntMap StgArg -> [StgArg] mkTupArgs _ [] _ = [] mkTupArgs arg_idx (slot : slots_left) arg_map | Just stg_arg <- IM.lookup arg_idx arg_map = stg_arg : mkTupArgs (arg_idx + 1) slots_left arg_map | otherwise = ubxSumRubbishArg slot : mkTupArgs (arg_idx + 1) slots_left arg_map in tag_arg : mkTupArgs 0 sum_slots arg_idxs -- | Return a rubbish value for the given slot type. -- -- We use the following rubbish values: -- * Literals: 0 or 0.0 -- * Pointers: `ghc-prim:GHC.Prim.Panic.absentSumFieldError` -- -- See Note [aBSENT_SUM_FIELD_ERROR_ID] in "GHC.Core.Make" -- ubxSumRubbishArg :: SlotTy -> StgArg ubxSumRubbishArg PtrLiftedSlot = StgVarArg aBSENT_SUM_FIELD_ERROR_ID ubxSumRubbishArg PtrUnliftedSlot = StgVarArg aBSENT_SUM_FIELD_ERROR_ID ubxSumRubbishArg WordSlot = StgLitArg (LitNumber LitNumWord 0) ubxSumRubbishArg Word64Slot = StgLitArg (LitNumber LitNumWord64 0) ubxSumRubbishArg FloatSlot = StgLitArg (LitFloat 0) ubxSumRubbishArg DoubleSlot = StgLitArg (LitDouble 0) -------------------------------------------------------------------------------- {- For arguments (StgArg) and binders (Id) we have two kind of unarisation: - When unarising function arg binders and arguments, we don't want to remove void binders and arguments. For example, f :: (# (# #), (# #) #) -> Void# -> RealWorld# -> ... f x y z =
Here after unarise we should still get a function with arity 3. Similarly in the call site we shouldn't remove void arguments: f (# (# #), (# #) #) voidId rw When unarising , we extend the environment with these binders: x :-> MultiVal [], y :-> MultiVal [], z :-> MultiVal [] Because their rep types are `MultiRep []` (aka. void). This means that when we see `x` in a function argument position, we actually replace it with a void argument. When we see it in a DataCon argument position, we just get rid of it, because DataCon applications in STG are always saturated. - When unarising case alternative binders we remove void binders, but we still update the environment the same way, because those binders may be used in the RHS. Example: case x of y { (# x1, x2, x3 #) ->