summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSolio Sarabia <solio.sarabia@intel.com>2017-12-12 14:25:22 -0800
committerStephen Hemminger <stephen@networkplumber.org>2017-12-14 18:12:14 -0800
commit051274b4db4e4992223d01b004b3d96f1f3f0ef5 (patch)
tree2387a145e4c87a13a960439ac53600453f1d7d29
parent3a2fbf007bba2a4b03255ef5465c538d6e95fab6 (diff)
downloadiproute2-051274b4db4e4992223d01b004b3d96f1f3f0ef5.tar.gz
iplink: validate maximum gso_max_size
Validate the upper limit for gso_max_size, valid range is [0-65,536] inclusive. Fix minor whitespace in iplink man page. Signed-off-by: Solio Sarabia <solio.sarabia@intel.com>
-rw-r--r--ip/iplink.c3
-rw-r--r--man/man8/ip-link.8.in2
2 files changed, 3 insertions, 2 deletions
diff --git a/ip/iplink.c b/ip/iplink.c
index 6379b16a..62bf713d 100644
--- a/ip/iplink.c
+++ b/ip/iplink.c
@@ -853,7 +853,8 @@ int iplink_parse(int argc, char **argv, struct iplink_req *req,
unsigned int max_size;
NEXT_ARG();
- if (get_unsigned(&max_size, *argv, 0) || max_size > UINT16_MAX)
+ if (get_unsigned(&max_size, *argv, 0) ||
+ max_size > UINT16_MAX + 1)
invarg("Invalid \"gso_max_size\" value\n",
*argv);
addattr32(&req->n, sizeof(*req), IFLA_GSO_MAX_SIZE, max_size);
diff --git a/man/man8/ip-link.8.in b/man/man8/ip-link.8.in
index 0db2582e..40f09b30 100644
--- a/man/man8/ip-link.8.in
+++ b/man/man8/ip-link.8.in
@@ -36,7 +36,7 @@ ip-link \- network device configuration
.RB "[ " numrxqueues
.IR QUEUE_COUNT " ]"
.br
-.BR "[" gso_max_size
+.BR "[ " gso_max_size
.IR BYTES " ]"
.RB "[ " gso_max_segs
.IR SEGMENTS " ]"