From 0c03eaefbbd3f0e22dd5df600c4b707af294890c Mon Sep 17 00:00:00 2001
From: Razvan Becheriu <razvan@isc.org>
Date: Thu, 13 Jan 2022 20:08:49 +0200
Subject: fixed compilation warning

---
 .gitignore        |  2 ++
 RELNOTES          |  3 +++
 client/dhclient.c | 10 +++++-----
 relay/dhcrelay.c  |  4 ++--
 server/dhcpd.c    |  4 ++--
 5 files changed, 14 insertions(+), 9 deletions(-)

diff --git a/.gitignore b/.gitignore
index 59eb7dd9..60c67238 100644
--- a/.gitignore
+++ b/.gitignore
@@ -9,6 +9,7 @@ client/tests/duid_unittests
 client/tests/test-suite.log
 common/tests/alloc_unittest
 common/tests/dns_unittest
+common/tests/domain_name_unittest
 common/tests/misc_unittest
 common/tests/ns_name_unittest
 common/tests/option_unittest
@@ -24,6 +25,7 @@ libtool
 ltmain.sh
 omapip/svtest
 relay/dhcrelay
+relay/tests/relay_unittests
 server/dhcpd
 server/tests/dhcpd_unittests
 server/tests/hash_unittests
diff --git a/RELNOTES b/RELNOTES
index 85a4515e..1dfff178 100644
--- a/RELNOTES
+++ b/RELNOTES
@@ -130,6 +130,9 @@ and the client Linux script sample was updated.
   convenient on all systems.
   [Gitlab #197]
 
+- Minor dhclient code fix to remove compilation warnings.
+  [Gitlab #190]
+
 		Changes since 4.4.2b1 (Bug Fixes)
 
 - Added a clarification on DHCPINFORMs and server authority to
diff --git a/client/dhclient.c b/client/dhclient.c
index a0ff656b..d06efa55 100644
--- a/client/dhclient.c
+++ b/client/dhclient.c
@@ -137,10 +137,10 @@ static void dhclient_ddns_cb_free(dhcp_ddns_cb_t *ddns_cb,
  * the description of the command line.  The arguments provide
  * a way for the caller to request more specific information about
  * the error be printed as well.  Mostly this will be that some
- * comamnd doesn't include its argument.
+ * command doesn't include its argument.
  *
  * \param sfmt - The basic string and format for the specific error
- * \param sarg - Generally the offending argument from the comamnd line.
+ * \param sarg - Generally the offending argument from the command line.
  *
  * \return Nothing
  */
@@ -567,7 +567,7 @@ main(int argc, char **argv) {
 		} else if (argv[i][0] == '-') {
 			usage("Unknown command: %s", argv[i]);
 		} else if (interfaces_requested < 0) {
-			usage("No interfaces comamnd -n and "
+			usage("No interfaces command -n and "
 			      " requested interface %s", argv[i]);
 		} else {
 		    struct interface_info *tmp = NULL;
@@ -3399,12 +3399,12 @@ make_client_options(struct client_state *client, struct client_lease *lease,
 			hw_idx = 0;
 			hw_len = client->interface->hw_address.hlen;
 		}
-		memcpy(&client_identifier.buffer->data + 5 - hw_len,
+		memcpy(client_identifier.buffer->data + 5 - hw_len,
 		       client->interface->hw_address.hbuf + hw_idx,
 		       hw_len);
 
 		/* Add the default duid */
-		memcpy(&client_identifier.buffer->data+(1+4),
+		memcpy(client_identifier.buffer->data + (1 + 4),
 		       default_duid.data, default_duid.len);
 
 		/* And save the option */
diff --git a/relay/dhcrelay.c b/relay/dhcrelay.c
index 7211e3bb..72b2b1f9 100644
--- a/relay/dhcrelay.c
+++ b/relay/dhcrelay.c
@@ -235,10 +235,10 @@ char *progname;
  * the description of the command line.  The arguments provide
  * a way for the caller to request more specific information about
  * the error be printed as well.  Mostly this will be that some
- * comamnd doesn't include its argument.
+ * command doesn't include its argument.
  *
  * \param sfmt - The basic string and format for the specific error
- * \param sarg - Generally the offending argument from the comamnd line.
+ * \param sarg - Generally the offending argument from the command line.
  *
  * \return Nothing
  */
diff --git a/server/dhcpd.c b/server/dhcpd.c
index 6c2ceedd..7b25d70d 100644
--- a/server/dhcpd.c
+++ b/server/dhcpd.c
@@ -195,10 +195,10 @@ static void omapi_listener_start (void *foo)
  * the description of the command line.  The arguments provide
  * a way for the caller to request more specific information about
  * the error be printed as well.  Mostly this will be that some
- * comamnd doesn't include its argument.
+ * command doesn't include its argument.
  *
  * \param sfmt - The basic string and format for the specific error
- * \param sarg - Generally the offending argument from the comamnd line.
+ * \param sarg - Generally the offending argument from the command line.
  *
  * \return Nothing
  */
-- 
cgit v1.2.1