From 0d3ac81be223190c616947bd84749aebb73a7d2b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Adri=C3=A1n=20Larumbe?= Date: Tue, 7 Jun 2022 18:27:13 +0100 Subject: kmscube: check return value when creating GBM device MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In the off-chance that gbm_create_device fails and returns a NULL value, further down the line a segfault will be triggered when dereferencing gbm.dev. Signed-off-by: Adrián Larumbe --- common.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/common.c b/common.c index 8ad0ad5..30d6017 100644 --- a/common.c +++ b/common.c @@ -124,7 +124,10 @@ const struct gbm * init_gbm(int drm_fd, int w, int h, uint32_t format, uint64_t modifier, bool surfaceless) { gbm.dev = gbm_create_device(drm_fd); - gbm.format = format; + if (!gbm.dev) + return NULL; + + gbm.format = format; gbm.surface = NULL; gbm.width = w; -- cgit v1.2.1