diff options
author | gabor@google.com <gabor@google.com@62dab493-f737-651d-591e-8d6aee1b9529> | 2011-06-22 02:36:45 +0000 |
---|---|---|
committer | gabor@google.com <gabor@google.com@62dab493-f737-651d-591e-8d6aee1b9529> | 2011-06-22 02:36:45 +0000 |
commit | ccf0fcd5c2946f9228068d657a56d91af9671575 (patch) | |
tree | 876b8a3e734972320aced5f0b33bf8bc34c5f101 /db/repair.cc | |
parent | 80e5b0d944b7651046f8b0e795065eca02a01e59 (diff) | |
download | leveldb-ccf0fcd5c2946f9228068d657a56d91af9671575.tar.gz |
A number of smaller fixes and performance improvements:
- Implemented Get() directly instead of building on top of a full
merging iterator stack. This speeds up the "readrandom" benchmark
by up to 15-30%.
- Fixed an opensource compilation problem.
Added --db=<name> flag to control where the database is placed.
- Automatically compact a file when we have done enough
overlapping seeks to that file.
- Fixed a performance bug where we would read from at least one
file in a level even if none of the files overlapped the key
being read.
- Makefile fix for Mac OSX installations that have XCode 4 without XCode 3.
- Unified the two occurrences of binary search in a file-list
into one routine.
- Found and fixed a bug where we would unnecessarily search the
last file when looking for a key larger than all data in the
level.
- A fix to avoid the need for trivial move compactions and
therefore gets rid of two out of five syncs in "fillseq".
- Removed the MANIFEST file write when switching to a new
memtable/log-file for a 10-20% improvement on fill speed on ext4.
- Adding a SNAPPY setting in the Makefile for folks who have
Snappy installed. Snappy compresses values and speeds up writes.
git-svn-id: https://leveldb.googlecode.com/svn/trunk@32 62dab493-f737-651d-591e-8d6aee1b9529
Diffstat (limited to 'db/repair.cc')
-rw-r--r-- | db/repair.cc | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/db/repair.cc b/db/repair.cc index 4b57169..ae1b136 100644 --- a/db/repair.cc +++ b/db/repair.cc @@ -212,14 +212,12 @@ class Repairer { } delete lfile; - // We ignore any version edits generated by the conversion to a Table + // Do not record a version edit for this conversion to a Table // since ExtractMetaData() will also generate edits. - VersionEdit skipped; FileMetaData meta; meta.number = next_file_number_++; Iterator* iter = mem->NewIterator(); - status = BuildTable(dbname_, env_, options_, table_cache_, iter, - &meta, &skipped); + status = BuildTable(dbname_, env_, options_, table_cache_, iter, &meta); delete iter; mem->Unref(); mem = NULL; |