diff options
author | gabor@google.com <gabor@google.com@62dab493-f737-651d-591e-8d6aee1b9529> | 2011-07-21 02:40:18 +0000 |
---|---|---|
committer | gabor@google.com <gabor@google.com@62dab493-f737-651d-591e-8d6aee1b9529> | 2011-07-21 02:40:18 +0000 |
commit | 60bd8015f21fdb63d5409b1191f8ea9d8f1a1b87 (patch) | |
tree | dab21fd0d1309be4e6851f690e1c011e79ddbf6b /util/env_chromium.cc | |
parent | 6872ace90110799f87402cbc594c4cbf1bc474c7 (diff) | |
download | leveldb-60bd8015f21fdb63d5409b1191f8ea9d8f1a1b87.tar.gz |
Speed up Snappy uncompression, new Logger interface.
- Removed one copy of an uncompressed block contents changing
the signature of Snappy_Uncompress() so it uncompresses into a
flat array instead of a std::string.
Speeds up readrandom ~10%.
- Instead of a combination of Env/WritableFile, we now have a
Logger interface that can be easily overridden applications
that want to supply their own logging.
- Separated out the gcc and Sun Studio parts of atomic_pointer.h
so we can use 'asm', 'volatile' keywords for Sun Studio.
git-svn-id: https://leveldb.googlecode.com/svn/trunk@39 62dab493-f737-651d-591e-8d6aee1b9529
Diffstat (limited to 'util/env_chromium.cc')
-rw-r--r-- | util/env_chromium.cc | 74 |
1 files changed, 13 insertions, 61 deletions
diff --git a/util/env_chromium.cc b/util/env_chromium.cc index 1af525a..975386b 100644 --- a/util/env_chromium.cc +++ b/util/env_chromium.cc @@ -23,6 +23,7 @@ #include "leveldb/slice.h" #include "port/port.h" #include "util/logging.h" +#include "util/posix_logger.h" #if defined(OS_WIN) #include <io.h> @@ -406,9 +407,8 @@ class ChromiumEnv : public Env { return Status::OK(); } - virtual void Logv(WritableFile* info_log, const char* format, va_list ap) { - // TODO(jorlow): We may want to just use Chromium's built in logging. - + // TODO(user,user): Use Chromium's built-in logging? + static uint64_t gettid() { uint64_t thread_id = 0; // Coppied from base/logging.cc. #if defined(OS_WIN) @@ -422,65 +422,17 @@ class ChromiumEnv : public Env { pthread_t tid = pthread_self(); memcpy(&thread_id, &tid, min(sizeof(r), sizeof(tid))); #endif + return thread_id; + } - // We try twice: the first time with a fixed-size stack allocated buffer, - // and the second time with a much larger dynamically allocated buffer. - char buffer[500]; - for (int iter = 0; iter < 2; iter++) { - char* base; - int bufsize; - if (iter == 0) { - bufsize = sizeof(buffer); - base = buffer; - } else { - bufsize = 30000; - base = new char[bufsize]; - } - char* p = base; - char* limit = base + bufsize; - - ::base::Time::Exploded t; - ::base::Time::Now().LocalExplode(&t); - p += snprintf(p, limit - p, - "%04d/%02d/%02d-%02d:%02d:%02d.%06d %llx ", - t.year, - t.month, - t.day_of_month, - t.hour, - t.minute, - t.second, - static_cast<int>(t.millisecond) * 1000, - static_cast<long long unsigned int>(thread_id)); - - // Print the message - if (p < limit) { - va_list backup_ap; - va_copy(backup_ap, ap); - p += vsnprintf(p, limit - p, format, backup_ap); - va_end(backup_ap); - } - - // Truncate to available space if necessary - if (p >= limit) { - if (iter == 0) { - continue; // Try again with larger buffer - } else { - p = limit - 1; - } - } - - // Add newline if necessary - if (p == base || p[-1] != '\n') { - *p++ = '\n'; - } - - assert(p <= limit); - info_log->Append(Slice(base, p - base)); - info_log->Flush(); - if (base != buffer) { - delete[] base; - } - break; + virtual Status NewLogger(const std::string& fname, Logger** result) { + FILE* f = fopen(fname.c_str(), "w"); + if (f == NULL) { + *result = NULL; + return Status::IOError(fname, strerror(errno)); + } else { + *result = new PosixLogger(f, &ChromiumEnv::gettid); + return Status::OK(); } } |